[with patch, positive review] tinymce should be disabled on published worksheets

[jason]

Otherwise bad things happen.

[mabshoff]

Positive review.

Cheers,

Michael

[mabshoff]

Merged in Sage 3.3.alpha4.

Cheers,

Michael

[mabshoff]

Ooops, this did break some doctests in cell.py:

sage -t -long "devel/sage/sage/server/notebook/cell.py"     
**********************************************************************
File "/scratch/mabshoff/sage-3.3.alpha4/devel/sage/sage/server/notebook/cell.py", line 175:
    sage: C.html()
Exception raised:
    Traceback (most recent call last):
      File "/scratch/mabshoff/sage-3.3.alpha4/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/scratch/mabshoff/sage-3.3.alpha4/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/scratch/mabshoff/sage-3.3.alpha4/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_9[3]>", line 1, in <module>
        C.html()###line 175:
    sage: C.html()
      File "/scratch/mabshoff/sage-3.3.alpha4/local/lib/python2.5/site-packages/sage/server/notebook/cell.py", line 184, in html
        if JEDITABLE_TINYMCE and not self.worksheet().is_published():
    AttributeError: 'NoneType' object has no attribute 'is_published'
**********************************************************************
File "/scratch/mabshoff/sage-3.3.alpha4/devel/sage/sage/server/notebook/cell.py", line 178:
    sage: C.html(do_math_parse=True)
Exception raised:
    Traceback (most recent call last):
      File "/scratch/mabshoff/sage-3.3.alpha4/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/scratch/mabshoff/sage-3.3.alpha4/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/scratch/mabshoff/sage-3.3.alpha4/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_9[5]>", line 1, in <module>
        C.html(do_math_parse=True)###line 178:
    sage: C.html(do_math_parse=True)
      File "/scratch/mabshoff/sage-3.3.alpha4/local/lib/python2.5/site-packages/sage/server/notebook/cell.py", line 184, in html
        if JEDITABLE_TINYMCE and not self.worksheet().is_published():
    AttributeError: 'NoneType' object has no attribute 'is_published'
**********************************************************************

Shame on me for giving this a positive review :p

Reopened.

Cheers,

Michel

[jason]

patch updated to check for the existence of the .is_published() method. It should work now.

[mabshoff]

Merged in Sage 3.3.alpha5.

Cheers,

Michael