Ticket #5094 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] Delete/Change SageX references to Cython

Reported by: kcrisman Owned by: tba
Priority: trivial Milestone: sage-3.3
Component: documentation Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

In 3.3.alpha0, there is still a reference to SageX in COPYING.txt. Any others should also be reported here.

Attachments

COPYING.txt Download (70.2 KB) - added by kcrisman 4 years ago.
This is a one-word change of SageX to Cython from the 3.3.alpha0 version of this file.
trac_5094.patch Download (12.0 KB) - added by kcrisman 4 years ago.
Based on 3.3.alpha0

Change History

comment:1 Changed 4 years ago by kcrisman

This is not a duplicate of #857; the reference is in the second line of the document.

Changed 4 years ago by kcrisman

This is a one-word change of SageX to Cython from the 3.3.alpha0 version of this file.

comment:2 Changed 4 years ago by kcrisman

Here are the others I have found. Most would be trivial to fix, but I don't know if all these files are long for this world.

misc/cython.py

In addition to one that should be there, there is one that it not!

rings/integer_mod_ring.py

An author credit should have Cython added

rings/padics/tutorial.py

Brief ref

calculus/var.pyx

Two references at G = globals()

graphs/graph_fast.pyx

The title refers to it

misc/reset.pyx

Two references at G = globals()

misc/sagex_ds.pyx

Includes references but of course is NAMED after it It appears to be used in misc/all.py and rings/polynomial/polynomial_compiled.pyx/.pxd, so need to change those in theory

rings/integer.pyx

Again a couple

rings/laurent_series_ring_element.pyx

Brief ref

rings/power_series_ring_element.pyx

Brief ref

rings/polynomial/polynomial_element.pyx

A couple references

ext/python.pxi

Quite a few references at the top

rings/real_rqdf.pyx

One ref, if this is even being kept

structure/parent_old.pyx

Several references, is this worth fixing?

libs/pari/gen.pyx

Brief ref

There were some in docs, but presumably that is not worth changing until after the Sphinx change: ref/module-sage.rings.integer-mod-ring.html ref/module-sage.rings.laurent-series-ring-element.html ref/module-sage.rings.padics.tutorial.html ref/module-sage.rings.polynomial.polynomial-element.html ref/module-sage.rings.power-series-ring-element.html ref/node343.html tut/node53.html (two examples, in SAGE_ROOT/examples/programming/sagex - should that directory be renamed as well?)

Changed 4 years ago by kcrisman

Based on 3.3.alpha0

comment:3 Changed 4 years ago by kcrisman

  • Summary changed from Delete/Change SageX references to Cython to Delete/Change SageX references to Cython [with patch and text, needs review]

comment:4 Changed 4 years ago by mabshoff

  • Summary changed from Delete/Change SageX references to Cython [with patch and text, needs review] to [with patch, positive review] Delete/Change SageX references to Cython
  • Milestone changed from sage-3.4.1 to sage-3.3

Positive review. That it touches python.pxi is rather unfortunate, but oh well ....

I guess in the long term we need to convert python.pxi to a pxd.

One last thing: The "[with patch, needs review]" goes to the front of the summary.

Cheers,

Michael

comment:5 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.3.alpha4.

Cheers,

Michael

Note: See TracTickets for help on using tickets.