[with patch; positive review] problem with "sage -c"

[was]

Create any script, say test.sage. The following should work but doesn't:

  # sage -c "load test.sage"
Traceback (most recent call last):
  File "/home/was/s/local/bin/sage-eval", line 10, in <module>
    eval(compile(s,tmp_filename(),'exec'))
  File "/home/was/.sage//temp/sage/25215//tmp_0", line 1
    load test.sage
            ^
SyntaxError: invalid syntax

[anakha]

Why is this supposed to work?

Anyway I did some investigation, and the problem comes from the fact that preparse() doesn't take care of "load test.sage" since that is done by ipython magic usually.

There is very complicated logic in sage-preparse to deal with those that would be inappropriate to reproduce in sage-eval.

Also there is a very simple workaround: sage test.sage

So I vote for 'wontfix' for this bug.

[was]

So I vote for 'wontfix' for this bug.

Just because you couldn't fix it and there is a workaround doesn't mean it isn't a bug.

And this is still a bug in sage-3.2:

teragon:tmp wstein$ more a.sage
print 2^3
teragon:tmp wstein$ sage -c "load a.sage"
Traceback (most recent call last):
  File "/Users/wstein/sage/local/bin/sage-eval", line 10, in <module>
    eval(compile(s,tmp_filename(),'exec'))
  File "/Users/wstein/.sage//temp/teragon.local/98089//tmp_0", line 1
    load a.sage
         ^
SyntaxError: invalid syntax

[anakha]

Fixes the problem by emulating load and attach.

It won't work with files that have spaces in their name because sage, sage-sage, sage-run, and various other are not ready to deal with that, yet.

[was]

This doesn't work because when sage-eval gets run the working directory is local/bin/, so the file test.sage isn't found. I bet you tested this patch with test.sage in SAGE_ROOT/local/bin/, which is the only case when this will work:

teragon-2:sage-3.2 wstein$ more test.sage
print "Hi"
teragon-2:sage-3.2 wstein$ ./sage -c "load test.sage"
/Users/wstein/sage/build/sage-3.2/local/bin/sage-preparse: File test.sage is missing
python: can't open file 'test.py': [Errno 2] No such file or directory
teragon-2:sage-3.2 wstein$ cp test.sage local/bin/
teragon-2:sage-3.2 wstein$ ./sage -c "load test.sage"
Hi

[abergeron]

It did work with 3.1.4 in other directories. But it doesn't with 3.2 and up as you pointed out.

Last patch fixes this.

[GeorgSWeber]

Target time for the review: January 12th

[GeorgSWeber]

Rescheduled for January 18th

[GeorgSWeber]

Works fine, and looks good to me. (Apply the v2 patch only; tested with Sage 3.2.3)

I adjusted the milestone because this patch does not interfere with the sphinxification.

[mabshoff]

Merged in Sage 3.3.alpha0