Ticket #5055 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] Trivial typo in interact documentation

Reported by: kcrisman Owned by: mhansen
Priority: trivial Milestone: sage-3.3
Component: interact Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

About halfway through the documentation of interact, there is this example:

sage: @interact
... def _(title=["A Plot Demo", "Something silly", "something tricky" , a=input_box(sin(x*sin(x*sin(x))), 'function'),
...     clr = Color('red'), thickness=[1..30], zoom=(1,0.95,..,0.1), plot_points=(200..2000)):
...     html('<h1 align=center>%s</h1>'%title)
...     print plot_points
...     show(plot(a, -zoom*pi,zoom*pi, color=clr, thickness=thickness, plot_points=plot_points))
<html>...

There should be a ] after the " after the word tricky.

Attachments

trac_5055.patch Download (744 bytes) - added by kcrisman 4 years ago.
Based on 3.3.alpha0

Change History

comment:1 follow-up: ↓ 2 Changed 4 years ago by mhansen

  • Owner changed from itolkov to mhansen
  • Status changed from new to assigned

Where are you seeing this error? I can't find it in any of the official Sage files. I'd vote for marking this as invalid.

comment:2 in reply to: ↑ 1 ; follow-up: ↓ 3 Changed 4 years ago by kcrisman

Replying to mhansen:

Where are you seeing this error? I can't find it in any of the official Sage files. I'd vote for marking this as invalid.

----------------------------------------------------------------------
| Sage Version 3.3.alpha0, Release Date: 2009-01-19                  |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
sage: interact?

And then it comes. Also, just above that, there is something about an interact "campus", which sounds odd to me... Anyway, this is pretty valid. Though trivial.

According to search_src('tricky'), it is in server/notebook/interact.py

comment:3 in reply to: ↑ 2 Changed 4 years ago by kcrisman

  • Summary changed from Trivial but fatal typo in interact documentation to Trivial typo in interact documentation

Or, rather, it seems to be valid in a disturbing way...

According to search_src('tricky'), it is in server/notebook/interact.py

Weirdly, when I actually look at that file, I see both []. So now the question is why doesn't this appear when I type

interact?

Instead, there is a space showing where the ] is in the actual file. But that is probably not for a typo ticket, so if it's reproducible it should be a separate ticket.

Attached is a patch fixing the word "campus" to "canvas", though, which is a trivial typo in the interact documentation.

Changed 4 years ago by kcrisman

Based on 3.3.alpha0

comment:4 Changed 4 years ago by kcrisman

  • Summary changed from Trivial typo in interact documentation to [with patch, needs review] Trivial typo in interact documentation

comment:5 Changed 4 years ago by malb

  • Summary changed from [with patch, needs review] Trivial typo in interact documentation to [with patch, positive review] Trivial typo in interact documentation

comment:6 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Milestone changed from sage-3.4.1 to sage-3.4

Merged in Sage 3.3.alpha3.

Cheers,

Michael

comment:7 Changed 4 years ago by mabshoff

  • Milestone changed from sage-3.4 to sage-3.3
Note: See TracTickets for help on using tickets.