Ticket #5035 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch; positive review] get doctest coverage of matrix_generic_dense.pyx up to 100%

Reported by: was Owned by: was
Priority: major Milestone: sage-3.3
Component: linear algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description


Attachments

trac_5035.patch Download (5.0 KB) - added by was 4 years ago.
this is against sage-3.3.alpha0
trac_5035_part2.patch Download (756 bytes) - added by was 4 years ago.

Change History

Changed 4 years ago by was

this is against sage-3.3.alpha0

comment:1 Changed 4 years ago by was

  • Summary changed from get doctest coverage of matrix_generic_dense.pyx up to 100% to [with patch; needs review] get doctest coverage of matrix_generic_dense.pyx up to 100%

comment:2 Changed 4 years ago by ddrake

The patch applies cleanly, but I get a doctest error: 

sage -t  "devel/sage-main/sage/matrix/matrix_generic_dense.pyx"
**********************************************************************
File "/var/tmp/sage-3.3.alpha0/devel/sage-main/sage/matrix/matrix_generic_dense.pyx", line 161:
    sage: hash(A)
Expected:
    -623270016
Got:
    139665060168050560
**********************************************************************
1 items had failures:
   1 of   6 in __main__.example_6
***Test Failed*** 1 failures.
For whitespace errors, see the file /var/tmp/sage-3.3.alpha0/tmp/.doctest_matrix_generic_dense.py
	 [1.1 s]
exit code: 1024

Changed 4 years ago by was

comment:3 Changed 4 years ago by ddrake

  • Summary changed from [with patch; needs review] get doctest coverage of matrix_generic_dense.pyx up to 100% to [with patch; positive review] get doctest coverage of matrix_generic_dense.pyx up to 100%

With both patches applied, we have 100% coverage, and the examples are nice. Positive review.

comment:4 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged both patches in Sage 3.3.alpha1

Note: See TracTickets for help on using tickets.