Ticket #5029 (closed enhancement: fixed)

Opened 13 months ago

Last modified 13 months ago

[with .egg, positive review] Better diffs for trac

Reported by: robertwb Owned by: mabshoff
Priority: critical Milestone: sage-3.3
Component: website/wiki Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

I got tired of not knowing what (new) file /dev/null is when reviewing tickets, or being able to see the hg comments, so I updated the hg plugin to show this info. I'm using this for trac.cython.org.

This just needs to go into the plugin directory of this trac server, and then restart the trac server. Make sure the filename matches the python version (e.g. py2.4 or py2.5), just rename it if not.

Attachments

HgBundleViewer-0.2-py2.4.egg Download (8.4 KB) - added by robertwb 13 months ago.

Change History

Changed 13 months ago by robertwb

Changed 13 months ago by robertwb

  • summary changed from Better diffs for trac to [with .egg, needs review] Better diffs for trac

Changed 13 months ago by schilly

  • owner changed from schilly to mabshoff
  • type changed from defect to enhancement

@mabshoff: this is probably for you since you are managing the trac server.

Changed 13 months ago by mhansen

Also, the Trac 0.11 series has a diff viewer that shows this information. Are we switching after SD12?

Changed 13 months ago by robertwb

Oh, I didn't know that. However we do it, it would be really handy.

Changed 13 months ago by mhansen

  • summary changed from [with .egg, needs review] Better diffs for trac to [with .egg, needs work] Better diffs for trac

I installed this on the Trac server, but it doesn't seem to work.

Changed 13 months ago by was

  • status changed from new to closed
  • resolution set to fixed

Changed 13 months ago by mabshoff

  • summary changed from [with .egg, needs work] Better diffs for trac to [with .egg, positive review] Better diffs for trac

Changed 13 months ago by mvngu

I got tired of not knowing what (new) file /dev/null is when reviewing tickets, or being able to see the hg comments,


Thanks, Robert, for raising this issue and have it fixed. With trac now able to display diff comments, it has made my life easier when it comes to crediting patch authors. Previously, I would need to download a patch in raw text format in order to see the patch author's name (and I'm bad at spelling people's names).

Note: See TracTickets for help on using tickets.