Ticket #5023 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] typo in calculus.py

Reported by: zimmerma Owned by: tba
Priority: trivial Milestone: sage-3.3
Component: documentation Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

at line 1372, algorithim should be algorithm

Attachments

trac-5023.patch Download (1.8 KB) - added by zimmerma 4 years ago.

Change History

Changed 4 years ago by zimmerma

comment:1 Changed 4 years ago by zimmerma

  • Summary changed from typo in calculus.py to [with patch, needs trivial review, and maybe new ticket] typo in calculus.py

The attachment fixes the above typo and two more. However for the last one (tahn -> tanh) I am concerned about the fact that there was no doctest for the corresponding function. 

sage: a=tanh(2)
sage: a._algebraic_(QQbar)
...
TypeError: Unable to coerce e (<class 'sage.functions.constants.E'>) to Rational

Did I something wrong? If not, a new ticket should be opened.

comment:2 Changed 4 years ago by jsp

  • Summary changed from [with patch, needs trivial review, and maybe new ticket] typo in calculus.py to [with patch, positive review, and maybe new ticket] typo in calculus.py

The patch corrected the typos, so a positive review.

But still 

[jaap@paix sage-3.3.alpha4]$ ./sage
----------------------------------------------------------------------
| Sage Version 3.3.alpha5, Release Date: 2009-02-03                  |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------

sage: a=tanh(2)

sage: a._algebraic_(QQbar)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)

[...]
TypeError: Unable to coerce e (<class 'sage.functions.constants.E'>) to Rational

Someone more knowledgeable should decide to open a new ticket or not.

Jaap

comment:3 Changed 4 years ago by mabshoff

  • Summary changed from [with patch, positive review, and maybe new ticket] typo in calculus.py to [with patch, positive review] typo in calculus.py

I have moved the issue Paul pointed out to #5191 so we can merge the spelling fixes.

Cheers,

Michael

comment:4 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.3.alpha6.

Cheers,

Michael

Note: See TracTickets for help on using tickets.