Ticket #4922 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, needs work] convert sage.monoids.* docstrings to Sphinx

Reported by: mhansen Owned by: tba
Priority: major Milestone: sage-3.4
Component: documentation Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description


Attachments

trac_4922.patch Download (17.1 KB) - added by mhansen 4 years ago.
sage.monoids-final.patch Download (16.8 KB) - added by mhansen 4 years ago.

Change History

Changed 4 years ago by mhansen

comment:1 Changed 4 years ago by mhansen

  • Summary changed from convert sage.monoids.* docstrings to Sphinx to [with patch, needs review] convert sage.monoids.* docstrings to Sphinx

comment:2 Changed 4 years ago by jhpalmieri

  • Summary changed from [with patch, needs review] convert sage.monoids.* docstrings to Sphinx to [with patch, needs work] convert sage.monoids.* docstrings to Sphinx

Looks good. One tiny change:

sage/monoids/free_monoid.py, line 156: change `i`th to `i`-th.

(This is in a function whose name starts with double underscores, so it isn't even in the reference manual. Just in case we add such things to the reference manual eventually, though...)

After this change, positive review.

Changed 4 years ago by mhansen

comment:3 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.4.alpha0.

Cheers,

Michael

Note: See TracTickets for help on using tickets.