Ticket #4882 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] M2 related doctest failure in sage/rings/polynomial/multi_polynomial_ideal.py

Reported by: jsp Owned by: mabshoff
Priority: major Milestone: sage-3.2.3
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

On Fedora 9, 32 bits:

sage -t  "devel/sage/sage/rings/polynomial/multi_polynomial_ideal.py"
**********************************************************************
File "/home/jaap/work/downloads/sage-3.2.2/devel/sage/sage/rings/polynomial/multi_polynomial_ideal.py", line 58:
    sage: S.<a,b> = R.quotient((x^2 + y^2, 17))
Expected:
    verbose 0 ... Warning: falling back to very slow toy implementation.
Got nothing
**********************************************************************
1 items had failures:
   1 of  47 in __main__.example_0
***Test Failed*** 1 failures.
For whitespace errors, see the file /home/jaap/downloads/sage-3.2.2/tmp/.doctest_multi_polynomial_ideal.py
	 [44.6 s]
exit code: 1024
 
----------------------------------------------------------------------
The following tests failed:


	sage -t  "devel/sage/sage/rings/polynomial/multi_polynomial_ideal.py"
Total time for all tests: 44.6 seconds

Jaap

Attachments

trac_4882.patch Download (2.0 KB) - added by mabshoff 4 years ago.
trac_4882-part2.patch Download (1.2 KB) - added by mabshoff 4 years ago.

Change History

comment:1 Changed 4 years ago by mabshoff

  • Owner changed from tbd to mabshoff
  • Status changed from new to assigned
  • Component changed from algebra to doctest
  • Summary changed from ./sage -t sage/sage/rings/polynomial/multi_polynomial_ideal.py M2 failure to [with patch, needs review] M2 related doctest failure in sage/rings/polynomial/multi_polynomial_ideal.py

Changed 4 years ago by mabshoff

comment:2 Changed 4 years ago by jsp

After the patch:

sage -t  "devel/sage/sage/rings/polynomial/multi_polynomial_ideal.py"
**********************************************************************
File "/home/jaap/work/downloads/sage-3.2.2/devel/sage/sage/rings/polynomial/multi_polynomial_ideal.py", line 65:
    sage: a^2 + b^2 == 0
Exception raised:
    Traceback (most recent call last):
      File "/home/jaap/downloads/sage-3.2.2.alpha2/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/home/jaap/downloads/sage-3.2.2.alpha2/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/home/jaap/downloads/sage-3.2.2.alpha2/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_0[16]>", line 1, in <module>
        a**Integer(2) + b**Integer(2) == Integer(0)###line 65:
    sage: a^2 + b^2 == 0
    NameError: name 'a' is not defined
**********************************************************************
File "/home/jaap/work/downloads/sage-3.2.2/devel/sage/sage/rings/polynomial/multi_polynomial_ideal.py", line 67:
    sage: a^3 - b^2
Exception raised:
    Traceback (most recent call last):
      File "/home/jaap/downloads/sage-3.2.2.alpha2/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/home/jaap/downloads/sage-3.2.2.alpha2/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/home/jaap/downloads/sage-3.2.2.alpha2/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_0[17]>", line 1, in <module>
        a**Integer(3) - b**Integer(2)###line 67:
    sage: a^3 - b^2
    NameError: name 'a' is not defined
**********************************************************************
File "/home/jaap/work/downloads/sage-3.2.2/devel/sage/sage/rings/polynomial/multi_polynomial_ideal.py", line 69:
    sage: (a+b)^17
Exception raised:
    Traceback (most recent call last):
      File "/home/jaap/downloads/sage-3.2.2.alpha2/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/home/jaap/downloads/sage-3.2.2.alpha2/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/home/jaap/downloads/sage-3.2.2.alpha2/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_0[18]>", line 1, in <module>
        (a+b)**Integer(17)###line 69:
    sage: (a+b)^17
    NameError: name 'a' is not defined
**********************************************************************
File "/home/jaap/work/downloads/sage-3.2.2/devel/sage/sage/rings/polynomial/multi_polynomial_ideal.py", line 71:
    sage: S(17) == 0
Exception raised:
    Traceback (most recent call last):
      File "/home/jaap/downloads/sage-3.2.2.alpha2/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/home/jaap/downloads/sage-3.2.2.alpha2/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/home/jaap/downloads/sage-3.2.2.alpha2/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_0[19]>", line 1, in <module>
        S(Integer(17)) == Integer(0)###line 71:
    sage: S(17) == 0
    NameError: name 'S' is not defined
**********************************************************************
1 items had failures:
   4 of  45 in __main__.example_0
***Test Failed*** 4 failures.
For whitespace errors, see the file /home/jaap/downloads/sage-3.2.2/tmp/.doctest_multi_polynomial_ideal.py
	 [12.6 s]
exit code: 1024
 

Needs work

Jaap

comment:3 Changed 4 years ago by mabshoff

  • Summary changed from [with patch, needs review] M2 related doctest failure in sage/rings/polynomial/multi_polynomial_ideal.py to [with patch, needs work] M2 related doctest failure in sage/rings/polynomial/multi_polynomial_ideal.py

Oops, my bad, A patch on top of that is coming up once sage.math is running again.

Cheers,

Michael

Changed 4 years ago by mabshoff

comment:4 Changed 4 years ago by mabshoff

  • Summary changed from [with patch, needs work] M2 related doctest failure in sage/rings/polynomial/multi_polynomial_ideal.py to [with patch, needs review] M2 related doctest failure in sage/rings/polynomial/multi_polynomial_ideal.py

Jaap,

a second patch to be applied on top of the other patch is up and should fix the issues. It even passes doctests now on my test box ;)

Cheers,

Michael

comment:5 Changed 4 years ago by jsp

  • Summary changed from [with patch, needs review] M2 related doctest failure in sage/rings/polynomial/multi_polynomial_ideal.py to [with patch, positive review] M2 related doctest failure in sage/rings/polynomial/multi_polynomial_ideal.py

Now:

sage -t  "devel/sage/sage/rings/polynomial/multi_polynomial_ideal.py"
	 [39.8 s]
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 39.8 seconds

Cheers,

Jaap

comment:6 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged both patches in Sage 3.2.3.final

Note: See TracTickets for help on using tickets.