Ticket #4861 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with spkg, positive review] Update FLINT to 1.0.20 (latest 1.0.x upstream)

Reported by: mabshoff Owned by: mabshoff
Priority: major Milestone: sage-3.2.3
Component: packages: standard Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

See Summary :)

Cheers,

Michael

Attachments

trac_4861.patch Download (2.4 KB) - added by mabshoff 4 years ago.

Change History

comment:1 Changed 4 years ago by mabshoff

  • Summary changed from Update FLINT to 1.0.20 (latest 1.0.x upstream) to [with spkg, needs review] Update FLINT to 1.0.20 (latest 1.0.x upstream)

The spkg at

 http://sage.math.washington.edu/home/mabshoff/release-cycles-3.2.3/alpha0/flint-1.0.20.spkg

provides the latest stable (1.0.x) FLINT release. Also note to apply the patch to the Sage library so that the FLINT dependent extensions are automatically rebuild for an updated FLINT.

Cheers,

Michael

Changed 4 years ago by mabshoff

comment:2 Changed 4 years ago by malb

  • Summary changed from [with spkg, needs review] Update FLINT to 1.0.20 (latest 1.0.x upstream) to [with spkg, needs work] Update FLINT to 1.0.20 (latest 1.0.x upstream)

Review

  • SPKG.txt is updated properly (+1)
  • hg status returns cleanly (+1)
  • doesn't seem to contain unneeded binary cruft (+1)
  • attached patch trac_4861.patch looks good (+1)
  • spkg-install works on sage.math (+1)
  • spkg-install runs test suite (-1)
  • make ptest passes on sage.math (+1)

"positive review" if the test suite is disabled or it is explained why it needs to be run.

comment:3 Changed 4 years ago by mabshoff

Every time we have upgrades FLINT we automatically run the test suite. This is usually turned off once we do the actual release.

Cheers,

Michael

comment:4 follow-up: ↓ 5 Changed 4 years ago by malb

I know, we just need to stick a reminder somewhere, don't we? If you disagree, just change it to positive review since the worst thing that can happen is an extra couple of minutes of build time.

comment:5 in reply to: ↑ 4 Changed 4 years ago by mabshoff

Replying to malb:

Hi Martin,

I know, we just need to stick a reminder somewhere, don't we? If you disagree, just change it to positive review since the worst thing that can happen is an extra couple of minutes of build time.

#4870 is now a blocker for 3.2.3 to turn it off before release. I would imagine this is a solution we can both live with.

Cheers,

Michael

comment:6 Changed 4 years ago by malb

  • Summary changed from [with spkg, needs work] Update FLINT to 1.0.20 (latest 1.0.x upstream) to [with spkg, positive review] Update FLINT to 1.0.20 (latest 1.0.x upstream)

comment:7 Changed 4 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.2.3.alpha0

Note: See TracTickets for help on using tickets.