Ticket #4823 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] better fix for determinant bug with speed regression fix

Reported by: robertwb Owned by: was
Priority: blocker Milestone: sage-3.2.2
Component: linear algebra Keywords:
Cc: cpernet Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

The fix at #3887 computes way to many primes, making det and hnf very slow. The attached patch resolves this issue and still gives correct output.

Attachments

4823-faster-fix.patch Download (774 bytes) - added by robertwb 4 years ago.

Change History

Changed 4 years ago by robertwb

comment:1 Changed 4 years ago by robertwb

  • Cc cpernet added

comment:2 Changed 4 years ago by cpernet

  • Status changed from new to closed
  • Resolution set to fixed
  • Summary changed from [with patch, needs review] to [with patch, positive review]

Patch looks correct and passes doctests.

comment:3 Changed 4 years ago by craigcitro

  • Status changed from closed to reopened
  • Resolution fixed deleted

I think we need to leave this as "open" until mabshoff merges the patch.

comment:4 Changed 4 years ago by was

  • Priority changed from critical to blocker

comment:5 Changed 4 years ago by mabshoff

How about a title for this ticket?

Cheers,

Michael

comment:6 Changed 4 years ago by craigcitro

  • Summary changed from [with patch, positive review] to [with patch, positive review] better fix for determinant bug

comment:7 Changed 4 years ago by mabshoff

  • Summary changed from [with patch, positive review] better fix for determinant bug to [with patch, positive review] better fix for determinant bug with speed regression fix

comment:8 Changed 4 years ago by mabshoff

  • Status changed from reopened to closed
  • Resolution set to fixed

Merged in Sage 3.2.2.rc2

Note: See TracTickets for help on using tickets.