Ticket #4787 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, positive review] Race condition in sage-doctest folder creation

Reported by: gfurnish Owned by: gfurnish
Priority: major Milestone: sage-3.2.2
Component: doctest coverage Keywords: mabshoff
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

There is a race condition in sage-doctest during folder creation at line 586, which is in a function called at line 441. This can cause doctesting a file to fail with file not found errors. This is different then the other file not found error that was in ptest.

Attachments

trac_4787_bin.patch Download (780 bytes) - added by gfurnish 4 years ago.

Change History

Changed 4 years ago by gfurnish

comment:1 Changed 4 years ago by gfurnish

  • Keywords mabshoff added
  • Status changed from new to assigned
  • Summary changed from Race condition in sage-doctest folder creation to [with patch, needs review] Race condition in sage-doctest folder creation

The line numbers in the description above should be switched -- basically in a rare case another sage-doctest can create the directories before this one creates them, but after it has decided they don't already exist. This tells it to ignore errors on making the directories -- they will still get caught later.

comment:2 Changed 4 years ago by mabshoff

  • Summary changed from [with patch, needs review] Race condition in sage-doctest folder creation to [with patch, positive review] Race condition in sage-doctest folder creation

Positive review.

Cheers,

Michael

comment:3 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 3.2.2.rc0

Note: See TracTickets for help on using tickets.