Ticket #4712 (closed defect: fixed)

Opened 21 months ago

Last modified 14 months ago

[with patch, positive review] Make the doctest timeouts in Sage easily adjustable

Reported by: mabshoff Owned by: mabshoff
Priority: major Milestone: sage-4.1
Component: doctest Keywords:
Cc: Author(s): John Palmieri
Report Upstream: Reviewer(s): Nick Alexander
Merged in: sage-4.1.alpha3 Work issues:

Description

This is a left over from #717. The fix here is to define some env variables that can be used to overwrite the default doctesting timeouts. Those are defined in sage-doctest right at the top:

# the default timeout for doctests: 6 minutes (in seconds)
TIMEOUT      = 20
# the timeout value for long doctests: 30 minutes (in seconds)
TIMEOUT_LONG = 30 * 60
# the timeout for doctests running under valgrind tools: unreasonably long
TIMEOUT_VALGRIND = 1024*1024

Canonical names would be IMHO:

SAGE_TIMEOUT
SAGE_TIMEOUT_LONG
SAGE_TIMEOUT_VALGRIND

Bonus points for running some performance counter once and then adjusting the timeout by some factor on slower machines.

Cheers,

Michael

Attachments

trac_4712_scripts.patch Download (1.7 KB) - added by jhpalmieri 15 months ago.

Change History

Changed 15 months ago by jhpalmieri

  • summary changed from Make the doctest timeouts in Sage easily adjustable to [with patch, needs review] Make the doctest timeouts in Sage easily adjustable

Here's a patch; apply to the scripts repository.

(This doesn't earn the bonus points Michael referred to.)

Changed 15 months ago by jhpalmieri

Changed 15 months ago by ncalexan

  • summary changed from [with patch, needs review] Make the doctest timeouts in Sage easily adjustable to [with patch, positive review] Make the doctest timeouts in Sage easily adjustable

Fine by me.

Changed 14 months ago by boothby

  • status changed from new to closed
  • resolution set to fixed
  • merged set to sage-4.1.alpha2

Changed 14 months ago by mvngu

  • reviewer set to Nick Alexander
  • author set to John Palmieri

Changed 14 months ago by rlm

  • merged changed from sage-4.1.alpha2 to sage-4.1.alpha3
Note: See TracTickets for help on using tickets.