Ticket #4708 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[with patch, with positive review] sage -tp doesn't test absolute file names nor does it ignore non-existent files

Reported by: ncalexan Owned by: gfurnish
Priority: major Milestone: sage-3.2.2
Component: doctest coverage Keywords: ptest parallel test absolute filename
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

-*- mode: sage-test; default-directory: "~/sage-3.2.1.alpha1/devel/sage-nca/sage/modules/" -*-
sage-test started at Thu Dec  4 20:43:38

/Users/ncalexan/bin/sage -b >/dev/null && /Users/ncalexan/bin/sage -tp 2 /Users/ncalexan/sage-3.2.1.alpha1/devel/sage-nca/sage/modules/free_module.py

real	0m1.413s
user	0m0.875s
sys	0m0.426s
Global iterations: 1
File iterations: 1
TeX files: 0
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 0.0 seconds

sage-test finished (all test passed) at Thu Dec  4 20:43:40

Also: 

-*- mode: sage-test; default-directory: "~/sage-3.2.1.alpha1/devel/sage-nca/sage/modules/" -*-
sage-test started at Thu Dec  4 20:44:39

/Users/ncalexan/bin/sage -b >/dev/null && /Users/ncalexan/bin/sage -t /Users/ncalexan/sage-3.2.1.alpha1/devel/sage-nca/sage/modules/free_module.py2

real	0m1.311s
user	0m0.872s
sys	0m0.416s
ERROR: File .//Users/ncalexan/sage-3.2.1.alpha1/devel/sage-nca/sage/modules/free_module.py2 is missing
exit code: 1
 
----------------------------------------------------------------------
The following tests failed:


	.//Users/ncalexan/sage-3.2.1.alpha1/devel/sage-nca/sage/modules/free_module.py2
Total time for all tests: 0.0 seconds

sage-test finished (all test passed) at Thu Dec  4 20:44:40

Attachments

trac_4708_bin.patch Download (879 bytes) - added by gfurnish 4 years ago.
4708_bin-2.patch Download (1.3 KB) - added by ncalexan 4 years ago.

Change History

Changed 4 years ago by gfurnish

comment:1 Changed 4 years ago by gfurnish

  • Owner changed from mabshoff to gfurnish
  • Status changed from new to assigned
  • Summary changed from sage -tp doesn't test absolute file names nor does it ignore non-existent files to [with patch, needs review] sage -tp doesn't test absolute file names nor does it ignore non-existent files

Trivial fix attached.

Changed 4 years ago by ncalexan

comment:2 Changed 4 years ago by ncalexan

  • Summary changed from [with patch, needs review] sage -tp doesn't test absolute file names nor does it ignore non-existent files to [with patch, with positive review] sage -tp doesn't test absolute file names nor does it ignore non-existent files

Apply only 4708_bin-2.patch, all credit to gfurnish.

comment:3 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged 4708_bin-2.patch in Sage 3.2.2.alpha0

Note: See TracTickets for help on using tickets.