Ticket #4688 (closed enhancement: fixed)
[with patch, with positive review] wrap pari functions idealstar and ideallog
| Reported by: | cremona | Owned by: | was |
|---|---|---|---|
| Priority: | major | Milestone: | sage-3.3 |
| Component: | number theory | Keywords: | |
| Cc: | m.t.aranes@… | Work issues: | |
| Report Upstream: | Reviewers: | ||
| Authors: | Merged in: | ||
| Dependencies: | Stopgaps: |
Description
If I is an ideal in the ring of integers R of a number field K, then the pari functions idealstar(K,I) returns the group (R/I)^* in the form of an abstract abelian group (order, invariants, and a list of generators). And ideallog() computes the discrete log with respect to I, i.e. given a in K with valuation 0 at all primes dividing I, returns a vector representing a mod I as an element of that abstract abelian group.
It would be very useful to have these wrapped in Sage. They appear in libs/pari/decl.pxi already so that should not be hard.
Attachments
-
trac_4688.patch
(4.7 KB) -
added by AlexGhitza 4 years ago.
Change History
comment:1 Changed 4 years ago by AlexGhitza
- Summary changed from wrap pari functions idealstar and ideallog to [with patch, needs review] wrap pari functions idealstar and ideallog
Maite Aranes wrote the code for wrapping the pari functions into Sage, and I reviewed it and added docstrings/doctests.
We need someone to review the docstrings, then this is ready to go.
comment:2 Changed 4 years ago by cremona
- Summary changed from [with patch, needs review] wrap pari functions idealstar and ideallog to [with patch, with positive review] wrap pari functions idealstar and ideallog
Postive review (and thanks to Alex for doing a good job on this). the patch applies fine to 3.3.rc0 and the tests in sage/libs/pari pass.
It will be easy to test this properly until we have Sage-level functions to access them, but that is being worked on and will be in a separate ticket, so this patch should PASS.
