Ticket #4640 (closed defect: fixed)

Opened 21 months ago

Last modified 18 months ago

[with patch, positive review] Do not dot out the number of pickles in the pickle jar doctest in sage/structure/sage_object.pyx, update pickle jar

Reported by: mabshoff Owned by: mabshoff
Priority: major Milestone: sage-3.4
Component: misc Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

[7:17pm] mabshoff: ws-4083: In the pickle jar doctest the number of pickles is dotted out. Shouldn't we hard code that number and update it every time we do the latest pickle jar?
[7:17pm] ws-4083 is now known as ws-3621.
[7:17pm] ws-3621: mabshoff -- sure, we could.
[7:18pm] ws-3621: I don't see why not.
[7:18pm] ws-3621: good idea.
[7:18pm] mabshoff: mk, ticket coming up.

Attachments

trac_4640.patch Download (1.1 KB) - added by mabshoff 18 months ago.

Change History

Changed 21 months ago by mabshoff

  • milestone changed from sage-3.4 to sage-3.2.2

If we are going to update the pickle jar for 3.2.2 we might as well fix this.

Cheers,

Michael

Changed 21 months ago by mabshoff

I am seeing two doctest failures, one which could have been caused by my dumb rebase attempt:

sage -t -long devel/sage/sage/structure/sage_object.pyx # 1 doctests 
sage -t -long devel/sage/sage/combinat/words/word_generators.py # 1 doctests failed

In detail: This might be caused by missing pickles in the pickle jar:

sage -t -long "devel/sage/sage/structure/sage_object.pyx"   
**********************************************************************
File "/scratch/mabshoff/release-cycle/sage-3.2.2.rc0/devel/sage/sage/structure/sage_object.pyx", line 371, in __main__.example_16
Failed example:
    sage.structure.sage_object.unpickle_all(std)###line 682:_sage_    >>> sage.structure.sage_object.unpickle_all(std)
Expected:
    doctest:...: DeprecationWarning: Your data is stored in an old format. Please use the save() function to store your data in a more recent format.
    Successfully unpickled ... objects.
    Failed to unpickle 0 objects.
Got:
    doctest:1172: DeprecationWarning: Your data is stored in an old format. Please use the save() function to store your data in a more recent format.
    ** failed:  _class__sage_combinat_word_Words_alphabet__.sobj
    ** failed:  _class__sage_combinat_word_Words_n__.sobj
    ** failed:  _class__sage_combinat_word_ShuffleProduct_overlapping__.sobj
    ** failed:  _class__sage_combinat_word_ShuffleProduct_shifted__.sobj
    ** failed:  _class__sage_combinat_word_ShuffleProduct_overlapping_r__.sobj
    ** failed:  _class__sage_combinat_word_ShuffleProduct_w1w2__.sobj
    Failed:
    _class__sage_combinat_word_Words_alphabet__.sobj
    _class__sage_combinat_word_Words_n__.sobj
    _class__sage_combinat_word_ShuffleProduct_overlapping__.sobj
    _class__sage_combinat_word_ShuffleProduct_shifted__.sobj
    _class__sage_combinat_word_ShuffleProduct_overlapping_r__.sobj
    _class__sage_combinat_word_ShuffleProduct_w1w2__.sobj
    Successfully unpickled 448 objects.
    Failed to unpickle 6 objects.
**********************************************************************

and

sage -t -long "devel/sage/sage/combinat/words/word_generators.py"
**********************************************************************
File "/scratch/mabshoff/release-cycle/sage-3.2.2.rc0/devel/sage/sage/combinat/words/word_generators.py", line 282, in __main__.example_6
Failed example:
    f[:Integer(10000)] == u[:Integer(10000)] #long time###line 286:_sage_    >>> f[:10000] == u[:10000] #long time
Expected:
    True
Got:
    False
**********************************************************************

Cheers,

Michael

Changed 21 months ago by mabshoff

oops, wrong ticket.

Cheers,

Michael

Changed 21 months ago by mabshoff

  • summary changed from Do not dot out the number of pickles in the pickle jar doctest in sage/structure/sage_object.pyx to Do not dot out the number of pickles in the pickle jar doctest in sage/structure/sage_object.pyx, update pickle jar

Changed 18 months ago by mabshoff

  • milestone changed from sage-3.4.2 to sage-3.4

Changed 18 months ago by mabshoff

Changed 18 months ago by mabshoff

  • status changed from new to assigned
  • summary changed from Do not dot out the number of pickles in the pickle jar doctest in sage/structure/sage_object.pyx, update pickle jar to [with patch, needs] Do not dot out the number of pickles in the pickle jar doctest in sage/structure/sage_object.pyx, update pickle jar

Changed 18 months ago by was

  • summary changed from [with patch, needs] Do not dot out the number of pickles in the pickle jar doctest in sage/structure/sage_object.pyx, update pickle jar to [with patch, positive review] Do not dot out the number of pickles in the pickle jar doctest in sage/structure/sage_object.pyx, update pickle jar

yes!

Changed 18 months ago by mabshoff

  • status changed from assigned to closed
  • resolution set to fixed

Merged in Sage 3.4.final.

Cheers,

Michael

Note: See TracTickets for help on using tickets.