Ticket #4557 (closed defect: fixed)

Opened 22 months ago

Last modified 22 months ago

[with patch, positive review] cos._fast_float_ returns math.sin

Reported by: jason Owned by: burcin
Priority: blocker Milestone: sage-3.2
Component: calculus Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

This is pretty embarrassing. Apparently a copy-paste error.

Attachments

trac-4557-cos-fast_float.patch Download (1.2 KB) - added by jason 22 months ago.

Change History

Changed 22 months ago by jason

  • summary changed from cos._fast_float_ returns math.sin to [with patch, needs review] cos._fast_float_ returns math.sin

Changed 22 months ago by jason

  • priority changed from major to blocker

Changed 22 months ago by mabshoff

  • summary changed from [with patch, needs review] cos._fast_float_ returns math.sin to [with patch, positive review] cos._fast_float_ returns math.sin

Oops. This patch will make it into 3.2.final.

Cheers,

Michael

Changed 22 months ago by jason

Changed 22 months ago by jason

added doctests.

Changed 22 months ago by mabshoff

Thanks for the doctests. I guess having some coverage tool of the code itself could be useful in the long term.

Cheers,

Michael

Changed 22 months ago by was

See #4561 for speed issues.

Changed 22 months ago by mabshoff

  • status changed from new to closed
  • resolution set to fixed

Merged in Sage 3.2.final

Note: See TracTickets for help on using tickets.