Ticket #4542 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] polyhedra bug fix and improvments

Reported by: mhampton Owned by: mhampton
Priority: major Milestone: sage-3.2.1
Component: geometry Keywords: polytopes
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

The attached patch fixes some big problems with defining polytopes through inequalities and linearities - defining via vertices has been tested a lot more. I also added some new functionality for making prisms, pyramids, taking unions and intersections, and a standard 3D polytope, the small rhombicuboctahedron.

Attachments

trac_4542.patch Download (9.9 KB) - added by mhampton 5 years ago.
patch for polyhedra.py, fixes linearity problem

Change History

Changed 5 years ago by mhampton

patch for polyhedra.py, fixes linearity problem

comment:1 Changed 5 years ago by mabshoff

  • Summary changed from polyhedra bug fix and improvments to [with patch, needs review] polyhedra bug fix and improvments

comment:2 Changed 5 years ago by cwitty

  • Summary changed from [with patch, needs review] polyhedra bug fix and improvments to [with patch, positive review] polyhedra bug fix and improvments

Looks good; doctests pass.

Positive review.

comment:3 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.2.1.alpha0

Note: See TracTickets for help on using tickets.