[with new patch, positive review] Stupid error in odd_part

[craigcitro]

I introduced an error in odd_part while working on #4443; the attached patch is the obvious fix, along with a doctest.

[mhansen]

Looks good.

[robertwb]

Wouldn't it be much faster to divide out by the valuation at 2?

[craigcitro]

Good point. I know I timed it when I wrote it (though I obviously didn't look at the output carefully) -- of course, since the broken version doesn't do much work, it's faster. Correcting it slows it way down.

Patch coming right up.

[craigcitro]

New patch, which should be much better. Unfortunately, it touches integer.pxd, so it takes a while to rebuild.

[jsp]

Applied trac-4534-v2.patch

Run ./sage -b and did a make check

All tests passed except the known issue with combinat/species/library.py

So I give this ticket a positive review.

Jaap

[mabshoff]

Merged trac-4534-v2.patch in Sage 3.2.rc2