Ticket #4507 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] compile warning for planarity code

Reported by: jason Owned by: rlm
Priority: major Milestone: sage-3.2
Component: graph theory Keywords:
Cc: ekirkman, bober Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

I get the following compile warning: 

gcc -fno-strict-aliasing -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/home/jason/sage/local//include -I/home/jason/sage/local//include/csage -I/home/jason/sage/devel//sage/sage/ext -I/home/jason/sage/local/include/python2.5 -c sage/graphs/planarity/graphEmbed.c -o build/temp.linux-i686-2.5/sage/graphs/planarity/graphEmbed.o
sage/graphs/planarity/graphEmbed.c: In function ‘_CreateSortedSeparatedDFSChildLists’:
sage/graphs/planarity/graphEmbed.c:84: warning: implicit declaration of function ‘memset’
sage/graphs/planarity/graphEmbed.c:84: warning: incompatible implicit declaration of built-in function ‘memset’

I fixed this by adding #include <string.h> (which declares the memset function) to listcoll.h (where the LCReset macro is defined).

Attachments

memset-not-declared.patch Download (562 bytes) - added by jason 5 years ago.

Change History

Changed 5 years ago by jason

comment:1 Changed 5 years ago by jason

  • Summary changed from compile warning for planarity code to [with patch, needs review] compile warning for planarity code

comment:2 Changed 5 years ago by jason

  • Cc ekirkman, bober added

comment:3 Changed 5 years ago by mabshoff

  • Summary changed from [with patch, needs review] compile warning for planarity code to [with patch, positive review] compile warning for planarity code

Positive review.

Cheers,

Michael

comment:4 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.2.rc1

Note: See TracTickets for help on using tickets.