Ticket #4488 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

[with patch, positive review] notebook -- login page not given when logged out and trying to view your worksheets

Reported by: TimothyClemans Owned by: TimothyClemans
Priority: major Milestone: sage-3.2.1
Component: notebook Keywords:
Cc: mhansen Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Should redirect to login page instead of giving an error message.

Attachments

sage-4488.patch Download (1019 bytes) - added by TimothyClemans 5 years ago.

Change History

Changed 5 years ago by TimothyClemans

comment:1 Changed 5 years ago by TimothyClemans

  • Summary changed from notebook -- login page not given when logged out and trying to view your worksheets to [with patch, needs review] notebook -- login page not given when logged out and trying to view your worksheets

comment:2 Changed 5 years ago by TimothyClemans

  • Owner changed from boothby to TimothyClemans
  • Status changed from new to assigned

comment:3 Changed 5 years ago by TimothyClemans

  • Cc mhansen added

Mike could you please review this? Thanks

comment:4 Changed 4 years ago by was

  • Summary changed from [with patch, needs review] notebook -- login page not given when logged out and trying to view your worksheets to [with patch, positive review] notebook -- login page not given when logged out and trying to view your worksheets

Looks very good. I like this and it moves things to be more the way standard web apps work. Plus it's a simple 2-liner which is well done.

comment:5 Changed 4 years ago by was

  • Milestone changed from sage-3.2.2 to sage-3.2.1

comment:6 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 3.2.1.rc0

Note: See TracTickets for help on using tickets.