Ticket #4449 (closed defect: fixed)
[with patch; positive review] sage-combinat install script doesn't work with 3.2.alpha2
| Reported by: | saliola | Owned by: | saliola |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-3.2 |
| Component: | combinatorics | Keywords: | sage-combinat |
| Cc: | sage-combinat | Work issues: | |
| Report Upstream: | Reviewers: | ||
| Authors: | Merged in: | ||
| Dependencies: | Stopgaps: |
Description
'sage -combinat install' on sage-3.2.alpha2 fails (and not on 'hg qpush -a').
Attachments
-
sage-combinat_4449.patch
(925 bytes) -
added by saliola 5 years ago.
Change History
comment:1 Changed 5 years ago by saliola
- Summary changed from sage-combinat install script doesn't work with 3.2.alpha2 to [with patch; needs review] sage-combinat install script doesn't work with 3.2.alpha2
The script fails because the following re.search in get_sage_version
return re.search('(\d+\.\d+\.\d+)',sage_version).group()
doesn't match anything for "3.2.alpha0". One way to get around this is to use a try-except statement (see the attached patch sage-combinat_4449.patch).
Now for 3.2.alpha2, the version number returned is '3.2.0' and for '3.2.1.alpha2' it is '3.2.1'. I think this should be okay since the version number is used to determine the guards (and the guards don't change much between alpha releases).
Now the script runs, and fails at the end during the 'hg qpush -a' (which is acceptable).
comment:3 Changed 5 years ago by mabshoff
- Summary changed from [with patch; needs review] sage-combinat install script doesn't work with 3.2.alpha2 to [with patch; positive review] sage-combinat install script doesn't work with 3.2.alpha2
Looks good to me. It won't catch all odd version numbers and nothing like x.y.z.w, but we don't use those any more.
Cheers,
Michael
