Ticket #4385 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] Sage 3.1.4: optional doctest failure in sage/rings/polynomial/multi_polynomial.pyx

Reported by: mabshoff Owned by: mhampton
Priority: minor Milestone: sage-3.2
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

sage -t -long -optional devel/sage/sage/rings/polynomial/multi_polynomial.pyx
**********************************************************************
File "/scratch/mabshoff/release-cycle/sage-3.2.alpha1/tmp/multi_polynomial.py", line 712:
    sage: P
Expected:
    A Polyhedron with 4 vertices.
Got:
    A Polyhedron with 3 vertices.
**********************************************************************
File "/scratch/mabshoff/release-cycle/sage-3.2.alpha1/tmp/multi_polynomial.py", line 721:
    sage: R(1).newton_polytope()
Expected:
    A Polyhedron with 1 vertices.
Got:
    A Polyhedron with 1 vertex.
**********************************************************************

Attachments

trac_4385.patch Download (1021 bytes) - added by mhampton 5 years ago.
simple fixes

Change History

Changed 5 years ago by mhampton

simple fixes

comment:1 Changed 5 years ago by mhampton

  • Priority changed from major to minor
  • Summary changed from Sage 3.1.4: optional doctest failure in sage/rings/polynomial/multi_polynomial.pyx to [with patch, needs review] Sage 3.1.4: optional doctest failure in sage/rings/polynomial/multi_polynomial.pyx

This is very simple, those optional tests just hadn't been hit in a while and the output needed to be changed. The "vertices" to "vertex" was just a grammatical fix. The 4 vertices to 3 is because Polyhedron objects now remove redundant vertices immediately.

comment:2 Changed 5 years ago by mabshoff

  • Summary changed from [with patch, needs review] Sage 3.1.4: optional doctest failure in sage/rings/polynomial/multi_polynomial.pyx to [with patch, positive review] Sage 3.1.4: optional doctest failure in sage/rings/polynomial/multi_polynomial.pyx

Patch looks good to me. Positive review.

Cheers,

Michael

comment:3 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.2.alpha2

Note: See TracTickets for help on using tickets.