Ticket #4377 (closed defect: fixed)

Opened 17 months ago

Last modified 17 months ago

[with patch; positive review] Building the Sage library with parallel make is broken on OSX 10.4

Reported by: mabshoff Owned by: mabshoff
Priority: critical Milestone: sage-3.2
Component: build Keywords:
Cc: justin Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

exporting MAKE=make -j2 leads to

Traceback (most recent call last):
  File "setup.py", line 1545, in <module>
    cython(deps, ext_modules)
  File "setup.py", line 1311, in cython
    execute_list_of_commands(command_list)
  File "setup.py", line 1403, in execute_list_of_commands
    n = 2*number_of_cpus()
TypeError: unsupported operand type(s) for *: 'int' and 'NoneType'
sage: There was an error installing modified sage library code.

on OSX 10.4.

This is caused by #3765.

Cheers,

Michael

Attachments

sage-4377.patch Download (1.2 KB) - added by was 17 months ago.

Change History

Changed 17 months ago by mabshoff

  • cc justin added

ok, the issue is simple enough and an extra "\n" in the output:

>>> import os
>>> os.popen2("sysctl -n hw.ncpu")[1].read()
'2\n'

Cheers,

Michael

Changed 17 months ago by mabshoff

Ok, the above wasn't the issue. Strange that number_of_cpus() returns None.

Cheers,

Michael

Changed 17 months ago by was

Changed 17 months ago by was

  • summary changed from Building the Sage library with parallel make is broken on OSX 10.4 to [with patch; needs review] Building the Sage library with parallel make is broken on OSX 10.4

Changed 17 months ago by mabshoff

  • summary changed from [with patch; needs review] Building the Sage library with parallel make is broken on OSX 10.4 to [with patch; positive review] Building the Sage library with parallel make is broken on OSX 10.4

The patch fixes the issue.

Cheers,

Michael

Changed 17 months ago by mabshoff

  • status changed from new to closed
  • resolution set to fixed

Merged in Sage 3.2.alpha2

Note: See TracTickets for help on using tickets.