Ticket #4324 (closed defect: fixed)

Opened 23 months ago

Last modified 23 months ago

[with patch, positive review] fix storage of GBs for PolyBoRi

Reported by: malb Owned by: tbd
Priority: critical Milestone: sage-3.2
Component: algebra Keywords:
Cc: PolyBoRi Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

The current code prevents certain GB calculations to finish because it throws a ValueError? just before the GB is returned (quit annoying).

Attachments

pbori_bugfix.patch Download (1.0 KB) - added by malb 23 months ago.

Change History

Changed 23 months ago by malb

Changed 23 months ago by PolyBoRi

  • summary changed from [with patch, needs review] fix storage of GBs for PolyBoRi to [with patch, positive review] fix storage of GBs for PolyBoRi

the patch is okay. Note, that the bug can only occur, when a system is passed, which is not a minimal GB. However, that's possible.

In the future version PolyBoRi? 0.6 pure reduction can be implemented more efficiently without handling sets. However, you will need a different workaround there 

r=ReductionStrategy()
if not p.lead() in r.leading_terms:
  r.add_generator(p)

Changed 23 months ago by mabshoff

  • status changed from new to closed
  • resolution set to fixed

Merged in Sage 3.2.alpha1

Note: See TracTickets for help on using tickets.