Ticket #4284 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] modular symbols -- applying Hecke operator on cuspidal subspace broken

Reported by: was Owned by: craigcitro
Priority: major Milestone: sage-3.2
Component: modular forms Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Bug in sage-3.1.2: 

sage: M = ModularSymbols(11).cuspidal_subspace(); M.hecke_operator(3)(M.0)

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)

/home/wstein/<ipython console> in <module>()

/home/wstein/sage/local/lib/python2.5/site-packages/sage/modular/hecke/hecke_operator.py in __call__(self, x)
    127         """
    128         T = self.hecke_module_morphism()
--> 129         return T(x)
    130
    131     def __rmul__(self, left):

/home/wstein/sage/local/lib/python2.5/site-packages/sage/modules/matrix_morphism.py in __call__(self, x)
    115             x = x.element()
    116         else:
--> 117             x = self.domain().coordinate_vector(x)
    118         v = x*self.matrix()
    119         C = self.codomain()

AttributeError: 'ModularSymbolsSubspace' object has no attribute 'coordinate_vector'

Attachments

trac-4284.patch Download (2.1 KB) - added by craigcitro 5 years ago.

Change History

Changed 5 years ago by craigcitro

comment:1 Changed 5 years ago by craigcitro

  • Owner changed from citro to craigcitro
  • Status changed from new to assigned
  • Summary changed from modular symbols -- applying Hecke operator on cuspidal subspace broken to [with patch, needs review] modular symbols -- applying Hecke operator on cuspidal subspace broken

Yep, this just wasn't tested at all. Fixed it, added some doctests.

comment:2 Changed 5 years ago by was

  • Summary changed from [with patch, needs review] modular symbols -- applying Hecke operator on cuspidal subspace broken to [with patch, positive review] modular symbols -- applying Hecke operator on cuspidal subspace broken

Looks good!

comment:3 Changed 5 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 3.2.alpha0

Note: See TracTickets for help on using tickets.