Ticket #4271 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, with positive review] improve coverage test of ell_generic.py to 100%, and fix typos

Reported by: zimmerma Owned by: mabshoff
Priority: trivial Milestone: sage-3.1.3
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

bash-3.00$ sage -t ell_generic.py
sage -t  devel/sage-main/sage/schemes/elliptic_curves/ell_generic.py
         [74.0 s]
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 74.0 seconds
bash-3.00$ sage -coverage ell_generic.py
----------------------------------------------------------------------
ell_generic.py
SCORE ell_generic.py: 100% (60 of 60)
----------------------------------------------------------------------

Attachments

10553.patch Download (12.0 KB) - added by zimmerma 5 years ago.

Change History

Changed 5 years ago by zimmerma

comment:1 follow-up: ↓ 2 Changed 5 years ago by cremona

  • Summary changed from [with patch, needs review] improve coverage test of ell_generic.py to 100%, and fix typos to [with patch, with positive review] improve coverage test of ell_generic.py to 100%, and fix typos

The patch is good. It apples cleanly to 3.1.3.alpha3 and works as advertised. Thanks, Paul -- almost all those typos were due to me!

John (in his lunch break in Bordeaux)

Michael: this only affects docstrings so should have no effect outside this one file.

comment:2 in reply to: ↑ 1 Changed 5 years ago by mabshoff

  • Milestone changed from sage-3.2 to sage-3.1.3

Replying to cremona:

Michael: this only affects docstrings so should have no effect outside this one file.

Hi John,

you actually beat me to a review and I was also convinced that this patch has 0% risk, so I will merge it into 3.1.3.

Cheers,

Michael

comment:3 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.1.3.final

Note: See TracTickets for help on using tickets.