Ticket #4269 (closed enhancement: fixed)

Opened 2 months ago

Last modified 1 month ago

[with patch, positive review] add code to help detect which systems are used in performing a computation

Reported by: mhansen Assigned to: mhansen
Priority: major Milestone: sage-3.2
Component: misc Keywords:
Cc:

Attachments

trac_4269.patch (4.3 kB) - added by mhansen on 10/12/2008 11:07:30 AM.
4269-referee.patch (1.0 kB) - added by robertwb on 10/14/2008 01:17:37 PM.

Change History

10/12/2008 11:07:30 AM changed by mhansen

  • attachment trac_4269.patch added.

10/12/2008 11:09:02 AM changed by mhansen

  • owner changed from cwitty to mhansen.
  • status changed from new to assigned.
  • summary changed from add code to help detect which systems are used in performing a computation to [with patch, needs review] add code to help detect which systems are used in performing a computation.

The detection strings could probably use some refinement, but I'm going to spend some time working one something else.

10/14/2008 01:17:37 PM changed by robertwb

  • attachment 4269-referee.patch added.

10/14/2008 01:19:02 PM changed by robertwb

I added a bit more of a disclaimer, and raised a better error on non-strings (so when one types get_systems('integrate(x^2, x)') one doesn't get an obscure error.

I give this a positive review, but someone should look at my changes.

10/21/2008 02:12:42 AM changed by PolyBoRi

  • summary changed from [with patch, needs review] add code to help detect which systems are used in performing a computation to [with patch, positive review] add code to help detect which systems are used in performing a computation.

I tested the type checking and ran some other example. Michael

10/25/2008 07:26:00 PM changed by mabshoff

  • status changed from assigned to closed.
  • resolution set to fixed.

Merged both patches in Sage 3.2.alpha1