Ticket #4262 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch; positive review] Elliptic curve a_invariants command returns a list reference (BAD!!)

Reported by: was Owned by: was
Priority: major Milestone: sage-3.1.3
Component: number theory Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

This sucks: 

sage: E = EllipticCurve([1,0,0,0,1])
sage: E.a_invariants()[0] = 100000000
sage: E
Elliptic Curve defined by y^2 + 100000000*x*y  = x^3 +1 over Rational Field

Attachments

sage-4262.patch Download (1.2 KB) - added by was 5 years ago.

Change History

Changed 5 years ago by was

comment:1 Changed 5 years ago by was

  • Summary changed from Elliptic curve a_invariants command returns a list reference (BAD!!) to [with patch; needs review] Elliptic curve a_invariants command returns a list reference (BAD!!)


comment:2 Changed 5 years ago by malb

Shouldn't we just return a tuple to emphasise that this is invariant?

comment:3 Changed 5 years ago by was

Changing to tuples should be another ticket.

comment:4 Changed 5 years ago by malb

  • Summary changed from [with patch; needs review] Elliptic curve a_invariants command returns a list reference (BAD!!) to [with patch; positive review] Elliptic curve a_invariants command returns a list reference (BAD!!)

comment:5 Changed 5 years ago by was

See #4264 for changing to return a tuple.

comment:6 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.1.3.rc0

Note: See TracTickets for help on using tickets.