[with patch, positive review] mq.SR improvements for convenience

This patch should probably have some doctests.

apply before other patch

added doctests

I added doctests and the patch this patch depends on which I forgot to submit last time.

REFEREE REPORT: I tried to figure out how to apply the above patches in their confusing order, but I guess I failed or something. See below (last patch fails to apply). Please clarify, and I'll referee this:

was@sage:~/build/sage-3.2.1.alpha1$ ./sage
----------------------------------------------------------------------
| Sage Version 3.2.1.alpha1, Release Date: 2008-11-26                |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
hgsage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/4254/sr_convenience.patch')
Attempting to load remote file: http://trac.sagemath.org/sage_trac/attachment/ticket/4254/sr_convenience.patch?format=raw
Loading: [.]
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg import   "/home/was/.sage/temp/sage/15295/tmp_0.patch"
applying /home/was/.sage/temp/sage/15295/tmp_0.patch
sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/4254/sr_parameters.patch')
Attempting to load remote file: http://trac.sagemath.org/sage_trac/attachment/ticket/4254/sr_parameters.patch?format=raw
Loading: [.]
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg import   "/home/was/.sage/temp/sage/15295/tmp_1.patch"
applying /home/was/.sage/temp/sage/15295/tmp_1.patch
sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/4254/sr_parameters.2.patch')
Attempting to load remote file: http://trac.sagemath.org/sage_trac/attachment/ticket/4254/sr_parameters.2.patch?format=raw
Loading: [.]
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg import   "/home/was/.sage/temp/sage/15295/tmp_2.patch"
applying /home/was/.sage/temp/sage/15295/tmp_2.patch
patching file sage/crypto/mq/sr.py
Hunk #2 FAILED at 288
1 out of 2 hunks FAILED -- saving rejects to file sage/crypto/mq/sr.py.rej
abort: patch failed to apply

and

was@sage:~/build/sage-3.2.1.alpha1$ more devel/sage/sage/crypto/mq/sr.py.rej
--- sr.py
+++ sr.py
@@ -284,8 +289,20 @@
             polybori = self._polybori
         except AttributeError:
             polybori = False
+        kwds.setdefault("polybori", polybori)
 
-        kwds.setdefault("polybori", polybori)
+        try:
+            correct_only = self._correct_only
+        except AttributeError:
+            correct_only = False
+        kwds.setdefault("correct_only", correct_only)
+
+        try:
+            biaffine_only = self._biaffine_only
+        except AttributeError:
+            biaffine_only = False
+        kwds.setdefault("biaffine_only", biaffine_only)
+
         return SR(**kwds)
 
     def __getattr__(self, attr):

Here is how to apply the patches:

$ hg qimport sr_convenience.patch
adding sr_convenience.patch to series file
$ hg qpush
applying sr_convenience.patch
Now at: sr_convenience.patch
$ hg qimport sr_parameters.patch
adding sr_parameters.patch to series file
$ hg qpush
applying sr_parameters.patch
Now at: sr_parameters.patch
$ sage -b

Note that sr_parameters.2.patch is sr_parameters.patch

If this passes doctests, then I give it a positive review.

Doctests pass, so this is a positive review by William.

Cheers,

Michael

Merged in Sage 3.2.1.rc1