Ticket #4226 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] Real Lazy Field

Reported by: robertwb Owned by: robertwb
Priority: major Milestone: sage-3.1.3
Component: coercion Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

This is needed for number field embedding.

Attachments

4226-real-lazy.patch Download (53.3 KB) - added by robertwb 5 years ago.
trac_4226-2.patch Download (1.7 KB) - added by mhansen 5 years ago.

Change History

Changed 5 years ago by robertwb

Changed 5 years ago by mhansen

comment:1 Changed 5 years ago by mhansen

  • Summary changed from [with patch, needs reivew] Real Lazy Field to [with patch, positive reivew] Real Lazy Field

Looks good to me. Note that the second patch should be applied as well since we got rid of the *_impl methods.

comment:2 Changed 5 years ago by mabshoff

The doctest "hash(RLF(sin(1)))" should probably not be #random, but should have separate #32 and #64 bit output.

Cheers,

Michael

comment:3 Changed 5 years ago by mabshoff

  • Summary changed from [with patch, positive reivew] Real Lazy Field to [with patch, positive review] Real Lazy Field

Fix a typo so the ticket is picked up by reports.

Cheers,

Michael

comment:4 Changed 5 years ago by mabshoff

I fixed the 32 vs. 64 bit hashing issue in a trivial patch.

Cheers,

Michael

comment:5 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.1.3.alpha3

comment:6 Changed 5 years ago by robertwb

Thanks for the fixes (I should have remembered that arithmetic patch got in).

Note: See TracTickets for help on using tickets.