Ticket #4186 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] speed up default __call__

Reported by: robertwb Owned by: robertwb
Priority: major Milestone: sage-3.1.3
Component: coercion Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

As this is used everywhere, I added a couple more optimizations. Cython generates less then optimal code here too, which I will fix.

Attachments

4186-faster-call.patch Download (3.1 KB) - added by robertwb 5 years ago.

Change History

Changed 5 years ago by robertwb

comment:1 Changed 5 years ago by mhansen

  • Summary changed from [with patch, needs review] speed up default __call__ to [with patch, positive review] speed up default __call__

Looks good to me.

comment:2 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.1.3.alpha1. It does not get the speed down to the old value, but shaves about 40 seconds off, so I will take this improvement :)

Cheers,

Michael

comment:3 Changed 5 years ago by robertwb

Hmm... It was faster on the subset of that test that I ran. There's still improvements to be made though (like when the new Cython comes out it should shave at least that much off again).

Note: See TracTickets for help on using tickets.