Ticket #4152 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

[with patch, positive review] parametric_plot should take the variable range as (var, min, max) like plot

Reported by: jason Owned by: mhansen
Priority: major Milestone: sage-3.3
Component: graphics Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

This should work to be consistent with plot: 

sage: parametric_plot((2*x, x^2+1), (x,0,1))
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)

/home/grout/<ipython console> in <module>()

TypeError: parametric_plot() takes exactly 3 arguments (2 given)

Attachments

trac_4152.patch Download (1.9 KB) - added by mhansen 4 years ago.
trac_4152-docs-dispatch.patch Download (4.2 KB) - added by jason 4 years ago.
apply on top of previous patch

Change History

comment:1 Changed 5 years ago by jason

This was also mentioned in #2410, but was not a fundamental part of that ticket.

Changed 4 years ago by mhansen

comment:2 Changed 4 years ago by mhansen

  • Owner changed from was to mhansen
  • Status changed from new to assigned
  • Summary changed from parametric_plot should take the variable range as (var, min, max) like plot to [with patch, needs review] parametric_plot should take the variable range as (var, min, max) like plot

Changed 4 years ago by jason

apply on top of previous patch

comment:3 Changed 4 years ago by jason

positive review for mhansen's patch. My patch further adds to the documentation and makes the parametric plot function dispatch the 3d version when needed. My patch needs to be reviewed.

comment:4 Changed 4 years ago by mhansen

  • Summary changed from [with patch, needs review] parametric_plot should take the variable range as (var, min, max) like plot to [with patch, positive review] parametric_plot should take the variable range as (var, min, max) like plot

Positive review for Jason's part.

comment:5 Changed 4 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Milestone changed from sage-3.4.1 to sage-3.3

Merged both patches in Sage 3.3.alpha0

Cheers,

Michael

Note: See TracTickets for help on using tickets.