Ticket #4150 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] migrate graphs to new refinement code

Reported by: rlm Owned by: rlm
Priority: major Milestone: sage-3.1.3
Component: graph theory Keywords:
Cc: jason Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

This moves the automorphism group and isomorphism functions for graphs over to the new framework. It should be tested on a few different architectures before getting merged.

Attachments

trac_4150-switchover-graphs.patch Download (15.1 KB) - added by rlm 5 years ago.
trac_4150-fixes.patch Download (3.4 KB) - added by rlm 5 years ago.

Change History

Changed 5 years ago by rlm

comment:1 Changed 5 years ago by rlm

Dependends on #4115, if you're applying to 3.1.2.final

comment:2 Changed 5 years ago by mhansen

Positive review for Robert's part. He just needs to sign off on my small second patch.

comment:3 Changed 5 years ago by rlm

+1

comment:4 Changed 5 years ago by mhansen

  • Summary changed from [with patch, needs review and testing] migrate graphs to new refinement code to [with patch, positive review and needs testing] migrate graphs to new refinement code

Note that the second patch depends on #4139 being applied.

comment:5 Changed 5 years ago by jason

  • Cc jason added

comment:6 Changed 5 years ago by mabshoff

The first hunk from trac_4150-fixes.patch ought to be deleted since I ended up fixing that doctest failure at #4139.

Cheers,

Michael

Changed 5 years ago by rlm

comment:7 Changed 5 years ago by rlm

Patch fixed.

comment:8 Changed 5 years ago by mabshoff

  • Summary changed from [with patch, positive review and needs testing] migrate graphs to new refinement code to [with patch, positive review] migrate graphs to new refinement code

Thanks, valgrinds clean and also works on Itanium with Python build with -fwrapv, which caused trouble with the old codebase, so what could go wrong :)

Cheers,

Michael

comment:9 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged both patches in Sage 3.1.3.alpha0

Note: See TracTickets for help on using tickets.