Ticket #4131 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[with patch, positive review] unbreak sage-clone

Reported by: mabshoff Owned by: mabshoff
Priority: major Milestone: sage-3.1.2
Component: build Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

Some bash code snuck into the python script sage-clone. This patch fixes it.

Cheers,

Michael

Attachments

trac_4131.patch Download (0.7 KB) - added by mabshoff 2 years ago.

Change History

Changed 2 years ago by mabshoff

  • status changed from new to assigned

Changed 2 years ago by mabshoff

Changed 2 years ago by mhansen

  • summary changed from [with patch, needs review] unbreak sage-clone to [with patch, positive review] unbreak sage-clone

Oops. :-)

Changed 2 years ago by wdj

I'm confused:

wdj@hera:~/sagefiles/sage-3.1.2.rc4$ ./sage
----------------------------------------------------------------------
| SAGE Version 3.1.2.rc4, Release Date: 2008-09-15                   |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------

sage: hg_sage.apply("/home/wdj/sagefiles/trac_4131.patch")
cd "/home/wdj/sagefiles/sage-3.1.2.rc4/devel/sage" && hg status
cd "/home/wdj/sagefiles/sage-3.1.2.rc4/devel/sage" && hg status
cd "/home/wdj/sagefiles/sage-3.1.2.rc4/devel/sage" && hg import   "/home/wdj/sagefiles/trac_4131.patch"
applying /home/wdj/sagefiles/trac_4131.patch
unable to find 'sage-clone' for patching
1 out of 1 hunk FAILED -- saving rejects to file sage-clone.rej
abort: patch failed to apply
sage:                                                

I see sage-clone in /home/wdj/sagefiles/sage-3.1.2.rc4/local/bin, so what the heck is going on?

Changed 2 years ago by mhansen

You use hg_scripts.apply() to apply this patch.

Changed 2 years ago by wdj

Thanks. Applied fine now and sage -clone is working:-)

Changed 2 years ago by mabshoff

  • status changed from assigned to closed
  • resolution set to fixed

Merged in Sage 3.1.2.rc5

Note: See TracTickets for help on using tickets.