Ticket #4130 (closed defect: fixed)
[with patch, positive review] #4125 does not work on OS X 10.4
| Reported by: | rlm | Owned by: | mabshoff |
|---|---|---|---|
| Priority: | blocker | Milestone: | sage-3.1.2 |
| Component: | build | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | Reviewers: | ||
| Authors: | Merged in: | ||
| Dependencies: | Stopgaps: |
Description
It looks like OS X 10.4.11's version of which doesn't behave very well...
hamptonio: nomad66-214:~ mh$ echo $PORTS_PATH [1:03pm] hamptonio: no port in /Volumes/D/sage-3.0.2 /Library/Frameworks/Python.framework/Versions/Current/bin /bin /sbin /usr/bin /usr/sbin /usr/local/bin /usr/local/teTeX/bin/i386-apple-darwin-current [1:03pm] hamptonio: nomad66-214:~ mh$ echo $FINK_PATH [1:03pm] hamptonio: no fink in /Volumes/D/sage-3.0.2 /Library/Frameworks/Python.framework/Versions/Current/bin /bin /sbin /usr/bin /usr/sbin /usr/local/bin /usr/local/teTeX/bin/i386-apple-darwin-current [1:03pm] hamptonio: nomad66-214:~ mh$ if [ "$PORTS_PATH" -o "$FINK_PATH" ]; then echo "*"; fi [1:03pm] hamptonio: *
Attachments
-
trac_4130.patch
(2.0 KB) -
added by mabshoff 5 years ago.
Change History
comment:1 Changed 5 years ago by mabshoff
- Status changed from new to assigned
- Summary changed from #4125 does not work on OS X 10.4 to [with patch, needs review] #4125 does not work on OS X 10.4
The attached patch has been tested on OSX 10.4 and 10.5, with and without Fink and/or MacPorts?. The patch also contains a fix to sage-env that was not yet in the spkg/base repo (since -sdist copies sage-env over without committing it to the repo).
Cheers,
Michael
comment:2 Changed 5 years ago by rlm
- Summary changed from [with patch, needs review] #4125 does not work on OS X 10.4 to [with patch, positive review] #4125 does not work on OS X 10.4
comment:3 Changed 5 years ago by mabshoff
- Status changed from assigned to closed
- Resolution set to fixed
Merged in Sage 3.1.2.rc5
comment:4 follow-up: ↓ 5 Changed 5 years ago by dphilp
hmmm... this is still not foolproof. If you type 'make', the first time, it dies with the proper message. But despite not setting any environment vairable, the second time you run 'make', there is no error, no warning, nothing.
I assume that the prereq script doesn't get called every time make is run? Maybe the fink/ports detection should go at the start.
comment:5 in reply to: ↑ 4 Changed 5 years ago by mabshoff
Replying to dphilp:
hmmm... this is still not foolproof. If you type 'make', the first time, it dies with the proper message. But despite not setting any environment vairable, the second time you run 'make', there is no error, no warning, nothing.
I assume that the prereq script doesn't get called every time make is run? Maybe the fink/ports detection should go at the start.
That issue is pretty much covered by #3140. This ticket was about fixing the OSX 10.4 issues, so closing it is valid. But thanks for being persistent :)
Cheers,
Michael
