Ticket #4099 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] Fix documentation for point2d, line2d, ...

Reported by: anakha Owned by: jwmerrill
Priority: major Milestone: sage-3.1.3
Component: documentation Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Since #3853, the documentation for the *2d functions in plot/plot.py is outdated.

It refers to things like point.options and line.reset which are gone and produce errors when you try to access them.

If I had the time I would do a patch for this, but I am currently swamped with other work.

Attachments

4099.patch Download (3.1 KB) - added by jwmerrill 5 years ago.

Change History

comment:1 Changed 5 years ago by mabshoff

  • Milestone set to sage-3.1.3

Changed 5 years ago by jwmerrill

comment:2 Changed 5 years ago by jwmerrill

  • Owner changed from tba to jwmerrill
  • Summary changed from Fix documentation for point2d, line2d, ... to [with patch, needs review] Fix documentation for point2d, line2d, ...

The patch just nukes all mention of .options and .reset. So far as I can tell, this functionality is gone without replacement. If there is now some other way to learn what these attributes used to tell you, then this patch should probably not be accepted, and the doc should be rewritten to explain the new functionality.

comment:3 Changed 5 years ago by mhansen

  • Summary changed from [with patch, needs review] Fix documentation for point2d, line2d, ... to [with patch, positive review] Fix documentation for point2d, line2d, ...

I think this is good for now.

comment:4 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.1.3.alpha0

Note: See TracTickets for help on using tickets.