Ticket #4086 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with spkg, positive review] Fix polybori-0.5rc.p3.spkg build issue from vanilla tarball

Reported by: mabshoff Owned by: mabshoff
Priority: major Milestone: sage-3.1.2
Component: packages: standard Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

In spkg-install we touch pbori.pyx to force a rebuild. But when building from a vanilla tarball that file does not exist and spkg-install exists with a non-zero status and fails. The spkg at

 http://sage.math.washington.edu/home/mabshoff/release-cycles-3.1.2/rc2/polybori-0.5rc.p4.spkg

fixes the issue.

Build tested on x86, x86-64 and Itanium Linux as well as OSX.

Cheers,

Michael

Change History

comment:1 Changed 5 years ago by mabshoff

  • Status changed from new to assigned

comment:2 Changed 5 years ago by malb

New spkg at:

 http://sage.math.washington.edu/home/malb/spkgs/polybori-0.5rc.p4.spkg

which replaces the test -a with test -f since that seems to be the safe choice. I only checked the SPKG by reading the changes, I didn't test it on a bunch of platforms yet.

comment:3 Changed 5 years ago by mabshoff

  • Summary changed from [with spkg, needs review] Fix polybori-0.5rc.p3.spkg build issue from vanilla tarball to [with spkg, positive review] Fix polybori-0.5rc.p3.spkg build issue from vanilla tarball

Spkg looks good to me. I will post a followup polybori-0.5rc.p5.spkg with the OSX 10.4 fix at #4090.

Cheers,

Michael

comment:4 Changed 5 years ago by mabshoff

  • Status changed from assigned to closed
  • Resolution set to fixed

Merged in Sage 3.1.2.rc2

comment:5 Changed 5 years ago by mabshoff

  • Milestone changed from sage-3.1.3 to sage-3.1.2
Note: See TracTickets for help on using tickets.