Ticket #4035 (closed defect: fixed)

Opened 3 months ago

Last modified 1 month ago

[with patch, positive review] fix optional doctests for multivariate polynomials

Reported by: malb Assigned to: malb
Priority: major Milestone: sage-3.2
Component: commutative algebra Keywords:
Cc: mhansen

Description

See attached patch.

Attachments

m2_optional_doctests.patch (4.5 kB) - added by malb on 09/01/2008 02:55:59 AM.

Change History

09/01/2008 02:55:59 AM changed by malb

  • attachment m2_optional_doctests.patch added.

09/01/2008 02:56:22 AM changed by malb

Gary, can you review this (I'm asking you since it involves M2)

09/03/2008 05:22:05 PM changed by mabshoff

I assume this ticket depends on the series of changes you made starting with the number field support? As is the patch does not apply.

Cheers,

Michael

09/03/2008 06:17:17 PM changed by malb

yeah, that could be.

09/20/2008 08:47:35 AM changed by malb

  • status changed from new to assigned.

10/26/2008 02:39:02 PM changed by mabshoff

  • cc changed from gfurnish to mhansen.
  • summary changed from [with patch, needs review] fix optional doctests for multivariate polynomials to [with patch, needs review, needs rebase] fix optional doctests for multivariate polynomials.

Unfortunately this patch has bitrotted: 

mabshoff@sage:/scratch/mabshoff/release-cycle/sage-3.2.alpha1/devel/sage$ patch -p1 < trac_4035_m2_optional_doctests.patch 
patching file sage/rings/polynomial/multi_polynomial.pyx
patching file sage/rings/polynomial/multi_polynomial_ideal.py
Hunk #1 FAILED at 60.
Hunk #2 succeeded at 1659 (offset 58 lines).
Hunk #3 succeeded at 1883 (offset 64 lines).
Hunk #4 FAILED at 2031.
2 out of 4 hunks FAILED -- saving rejects to file sage/rings/polynomial/multi_polynomial_ideal.py.rej
patching file sage/rings/polynomial/multi_polynomial_ring.py

Mike: Once it is rebased can you review it?

Cheers,

Michael

11/02/2008 08:16:22 AM changed by mabshoff

  • status changed from assigned to closed.
  • resolution set to fixed.
  • milestone changed from sage-3.2.1 to sage-3.2.

Fixed via the patch at #4420.

Cheers,

Michael

11/02/2008 08:17:26 AM changed by mabshoff

  • summary changed from [with patch, needs review, needs rebase] fix optional doctests for multivariate polynomials to [with patch, positive review] fix optional doctests for multivariate polynomials.