Ticket #4021 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[with patch, positive review] MPolynomial_libsingular over ZZ

Reported by: malb Owned by: malb
Priority: major Milestone: sage-3.1.3
Component: commutative algebra Keywords: libsingular, singular, ZZ, multivariate
Cc: was Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description

There it is.

Attachments

mpolynomial_libsingular_zz.patch Download (76.1 KB) - added by malb 2 years ago.
mpolynomial_zz_reduce_doc.patch Download (1.4 KB) - added by malb 2 years ago.
trac4021-doctest-fix.patch Download (0.8 KB) - added by AlexGhitza 2 years ago.

Change History

Changed 2 years ago by malb

Changed 2 years ago by malb

the attached patch depends on #686

Changed 2 years ago by malb

On [sage-devel] Oliver Wienand (author of the upcoming Singular implementation for GBs over rings) wrote:

I have just glimpsed over the code. But maybe it is worth stating in the comments, that the reduce impl. only returns unqiue answer against strong Gröbner basis.

Gröbner basis G of I <=> the leading ideal of G generates all leading terms of I strong % of I <=> for every leading term t of I there exists an element g of G, such that the leading term of g divides t.

(leading terms means coef * product of variables)

Otherwise the reduce code shown in  http://trac.sagemath.org/sage_trac/attachment/ticket/4021/mpolynomial_libsingular_zz.patch looks fine.

Changed 2 years ago by malb

  • status changed from new to assigned

Changed 2 years ago by malb

Changed 2 years ago by malb

The second patch addresses the review of Oliver Wienand on [sage-devel]:

I have just glimpsed over the code. But maybe it is worth stating in
the comments, that the reduce impl. only returns unqiue answer against
strong Gröbner basis.

Gröbner basis G of I <=> the leading ideal of G generates all leading
terms of I
strong % of I <=> for every leading term t of I there exists an
element g of G, such that the leading term of g divides t.

(leading terms meaans coef * product of variables)

Otherwise the reduce code shown in
http://trac.sagemath.org/sage_trac/attachment/ticket/4021/mpolynomial_libsingular_zz.patch
looks fine.

Changed 2 years ago by AlexGhitza

Changed 2 years ago by AlexGhitza

  • summary changed from [with patch, needs review] MPolynomial_libsingular over ZZ to [with patch, positive review] MPolynomial_libsingular over ZZ

Applies cleanly on 3.1.3.alpha1 + the patch at #686, except for a reject in rings/polynomial/multi_polynomial_libsingular.pyx, which can be ignored.

There is a tiny doctest failure in rings/polynomial/multi_polynomial_element.py which is fixed by the attached patch.

Changed 2 years ago by mabshoff

Merged all three patches in Sage 3.1.3.alpha2

Changed 2 years ago by mabshoff

  • status changed from assigned to closed
  • resolution set to fixed

Merged all three patches in Sage 3.1.3.alpha2 and this time I closed the ticket :)

Note: See TracTickets for help on using tickets.