Ticket #4019 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch, positive review] numerator and denominator for QQ[x]

Reported by: robertwb Owned by: tbd
Priority: major Milestone: sage-3.1.2
Component: algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

QQ[x] should have a numerator and denominator method.

Attachments

4019-QQx-numer.patch Download (1.7 KB) - added by robertwb 5 years ago.

Change History

Changed 5 years ago by robertwb

comment:1 Changed 5 years ago by AlexGhitza

The code looks fine. However, I'm getting a doctest failure in finite_field_ntl_gf2e.pyx: 

File "/opt/sage/tmp/finite_field_ntl_gf2e.py", line 1018:
    sage: e == f
Expected:
    True
Got:
    False

I can't tell where this is coming from.

comment:2 Changed 5 years ago by AlexGhitza

  • Summary changed from [with patch, needs review] numerator and denominator for QQ[x] to [with patch, mostly positive review] numerator and denominator for QQ[x]

comment:3 Changed 5 years ago by mabshoff

  • Summary changed from [with patch, mostly positive review] numerator and denominator for QQ[x] to [with patch, needs work] numerator and denominator for QQ[x]

I am changing the subject to "needs work" so that the various report will pick up this ticket.

Cheers,

Michael

comment:4 follow-up: ↓ 5 Changed 5 years ago by robertwb

I have been unable to reproduce this error, are you sure it's from this patch?

comment:5 in reply to: ↑ 4 Changed 5 years ago by mabshoff

  • Summary changed from [with patch, needs work] numerator and denominator for QQ[x] to [with patch, positive review] numerator and denominator for QQ[x]

Replying to robertwb:

I have been unable to reproduce this error, are you sure it's from this patch?

Robert, Alex,

applying this patch only to my merge tree does not result in any doctest failure, so I am giving this a positive review. Hopefully this will not bit us in the ass down the road ;)

Cheers,

Michael

comment:6 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.1.2.alpha4

Note: See TracTickets for help on using tickets.