Ticket #3923 (closed enhancement: fixed)

Opened 3 months ago

Last modified 1 month ago

[with patch, positive review] notebook -- convert existing templates to Jinja templates

Reported by: TimothyClemans Assigned to: mhansen
Priority: major Milestone: sage-3.2
Component: notebook Keywords:
Cc:

Description

Requires the Jinja Template Engine http://jinja.pocoo.org/2/

Attachments

sage-3923_1.patch (3.3 kB) - added by TimothyClemans on 08/21/2008 05:16:46 PM.
extcode-3923_1.patch (6.8 kB) - added by TimothyClemans on 08/21/2008 05:17:07 PM.
extcode-3923_2.patch (6.2 kB) - added by TimothyClemans on 08/23/2008 10:25:29 AM.
sage-3923_2.patch (12.2 kB) - added by TimothyClemans on 08/23/2008 10:26:03 AM.
sage-3923_3.patch (4.4 kB) - added by TimothyClemans on 08/23/2008 10:47:18 AM.
extcode-3923_3.patch (6.0 kB) - added by TimothyClemans on 08/23/2008 10:53:41 AM.
removes old files
trac_3923.patch (22.5 kB) - added by mhansen on 10/23/2008 03:35:32 PM.

Change History

08/21/2008 05:16:46 PM changed by TimothyClemans

  • attachment sage-3923_1.patch added.

08/21/2008 05:17:07 PM changed by TimothyClemans

  • attachment extcode-3923_1.patch added.

08/23/2008 10:25:29 AM changed by TimothyClemans

  • attachment extcode-3923_2.patch added.

08/23/2008 10:26:03 AM changed by TimothyClemans

  • attachment sage-3923_2.patch added.

08/23/2008 10:47:18 AM changed by TimothyClemans

  • attachment sage-3923_3.patch added.

08/23/2008 10:53:41 AM changed by TimothyClemans

  • attachment extcode-3923_3.patch added.

removes old files

08/23/2008 10:54:06 AM changed by TimothyClemans

  • summary changed from [with patch, not ready for review] notebook -- convert existing templates to Jinja templates to [with patch, needs review] notebook -- convert existing templates to Jinja templates.

(follow-up: ↓ 3 ) 09/24/2008 04:04:20 AM changed by malb

  • summary changed from [with patch, needs review] notebook -- convert existing templates to Jinja templates to [with patch, needs jinja] notebook -- convert existing templates to Jinja templates.

I think that this is not ready for review until Jinja is in Sage, if it ever gets into Sage.

(in reply to: ↑ 2 ; follow-up: ↓ 4 ) 09/24/2008 04:09:39 AM changed by mabshoff

Replying to malb:

I think that this is not ready for review until Jinja is in Sage, if it ever gets into Sage.

Jinja is required for the ReST transition of the documentation, so I am very bullish that it will get in. In total the ReST tool chain in 4 spkg weights in at 2MB compressed total and since it is a large improvement over the current situation with latex2html I think it will happen soon. Mike Hansen is pretty much ready to go here and it seems likely that those changes will be in 3.2.x if not 3.2 (assuming the spkgs get voted in obviously :))

Cheers,

Michael

(in reply to: ↑ 3 ; follow-up: ↓ 5 ) 09/24/2008 04:24:18 AM changed by malb

Replying to mabshoff:

Jinja is required for the ReST transition of the documentation, so I am very bullish that it will get in. In total the ReST tool chain in 4 spkg weights in at 2MB compressed total and since it is a large improvement over the current situation with latex2html I think it will happen soon. Mike Hansen is pretty much ready to go here and it seems likely that those changes will be in 3.2.x if not 3.2 (assuming the spkgs get voted in obviously :))

Don't get me wrong, I'm all in favor of Jinja getting in, but this still needs formal verification. Also, IIRC there is the issue of Jinja v1 (ReST) vs. v2 (this patch)?

(in reply to: ↑ 4 ) 09/24/2008 04:29:36 AM changed by mabshoff

Replying to malb:

Don't get me wrong, I'm all in favor of Jinja getting in, but this still needs formal verification. Also, IIRC there is the issue of Jinja v1 (ReST) vs. v2 (this patch)?

Sure, I agree. Mike has figured out IIRC that both Jinja and ReST and this code plays well together with Jinja v2. Timothy should have actually checked with [sage-devel] formally before going off into the sunset and code up loads of features that the code in question would actually be merged. But this story is likely to have a happy end :). Hopefully everyone involved here will learn a lesson from this.

Cheers,

Michael

10/23/2008 03:35:32 PM changed by mhansen

  • attachment trac_3923.patch added.

10/23/2008 04:15:22 PM changed by mhansen

  • owner changed from boothby to mhansen.
  • status changed from new to assigned.
  • summary changed from [with patch, needs jinja] notebook -- convert existing templates to Jinja templates to [with patch, positive review] notebook -- convert existing templates to Jinja templates.

I rebased the patches against 3.2.alpha0, moved the templates from extcode to sage/server/notebook/templates/, and changed the imports to use Jinja1 instead of Jinja2.

Apply only trac_3923.patch.

10/25/2008 03:55:09 PM changed by mabshoff

  • status changed from assigned to closed.
  • resolution set to fixed.

Merged trac_3923.patch in Sage 3.2.alpha1