Ticket #3849 (closed defect: fixed)

Opened 4 years ago

Last modified 2 years ago

notebook --get rid of internal server errors when uploading a worksheet

Reported by: TimothyClemans Owned by: TimothyClemans
Priority: major Milestone: sage-4.3
Component: notebook Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Mitesh Patel
Authors: William Stein Merged in:
Dependencies: Stopgaps:

Description (last modified by was) (diff)

If you upload a worksheet that doesn't exist or leave the worksheet upload page blank, or enter an invalid url, there are currently internal server errors. Fix this. See also the related #7495 for the same problem for uploading data (where there is also a critical security vulnerability).

Attachments

sage-3844_1.patch Download (1.5 KB) - added by TimothyClemans 4 years ago.
sage-3849_1.patch Download (1.5 KB) - added by TimothyClemans 4 years ago.
sagenb_3849.patch Download (3.7 KB) - added by was 2 years ago.
sagenb_3849.2.patch Download (4.6 KB) - added by mpatel 2 years ago.
Version 2. Added backlink. Apply only this patch to the sagenb repo.

Change History

comment:1 Changed 4 years ago by TimothyClemans

  • Owner changed from boothby to TimothyClemans
  • Status changed from new to assigned

comment:2 Changed 4 years ago by TimothyClemans

Error reporting does exist for file extension errors. However, it is not inline.

Changed 4 years ago by TimothyClemans

comment:3 Changed 4 years ago by TimothyClemans

  • Summary changed from notebook -- Internal Server Error given when input to File upload or Data attachment is invalid to [with patch, do not review] notebook -- Internal Server Error given when input to File upload or Data attachment is invalid

Took care of (1) and also now clicking "Upload Worksheet" when form blank no longer displays "Internal Server Error."

Changed 4 years ago by TimothyClemans

comment:4 Changed 2 years ago by was

Forget about this code. This is an important error though.

The attached patch sagenb_3849-part1.patch I think completely fixes all such problems for uploading a *worksheet*, but doesn't do anything about Data-->Upload or attach file.

I'm making Data -->Upload or attach a file a new ticket: #7495

comment:5 Changed 2 years ago by was

  • Description modified (diff)
  • Summary changed from [with patch, do not review] notebook -- Internal Server Error given when input to File upload or Data attachment is invalid to notebook --get rid of internal server errors when uploading a worksheet

comment:6 Changed 2 years ago by was

  • Status changed from needs_work to needs_review

Changed 2 years ago by was

Changed 2 years ago by mpatel

Version 2. Added backlink. Apply only this patch to the sagenb repo.

comment:7 follow-up: ↓ 8 Changed 2 years ago by mpatel

  • Reviewers set to Mitesh Patel
  • Authors set to William Stein

Version 2:

  • Adds a link back to the upload page.
  • sage-support --> sage-support group.

My review, to the extent it counts, is positive.

comment:8 in reply to: ↑ 7 Changed 2 years ago by timdumol

  • Status changed from needs_review to positive_review
  • Report Upstream set to N/A

Replying to mpatel:

[...] My review, to the extent it counts, is positive.

I'm giving this a positive review. Everything works fine.

comment:9 Changed 2 years ago by was

  • Status changed from positive_review to closed
  • Resolution set to fixed

merged into sage-4.3

Note: See TracTickets for help on using tickets.