Ticket #3835 (closed enhancement: fixed)

Opened 5 years ago

Last modified 4 years ago

[with patch, positive review] Make an algebraic closure function

Reported by: jason Owned by: tbd
Priority: major Milestone: sage-4.1.2
Component: algebra Keywords: fields
Cc: ncalexan Work issues:
Report Upstream: Reviewers: Mike Hansen
Authors: John Cremona Merged in: Sage 4.1.2.alpha2
Dependencies: Stopgaps:

Description

It would be nice to be able to construct the algebraic closure of an object. For example, QQ.algebraic_closure() should return QQbar.

Attachments

trac_3835-algebraic_closure.patch Download (4.5 KB) - added by cremona 4 years ago.
Applies to 4.1.1

Change History

Changed 4 years ago by cremona

Applies to 4.1.1

comment:1 Changed 4 years ago by cremona

  • Keywords fields added
  • Summary changed from Make an algebraic closure function to [with patch, needs review] Make an algebraic closure function
  • Authors set to John Cremona

The attached patch implements this in the trivial cases now possible: for a number field (including QQ) return QQbar; for RR return CC, with the same precision (this was already implemented); for CC, return the same field; for finite fields, raise NotImplementedError?; else raise NotImplementedError?.

I'm not sure if this is what Jason intended, but it would be a major undertaking to implement this in any other cases (finite fields, p-adic fields, function fields. ...)

comment:2 Changed 4 years ago by jason

My use-case at the time was QQ -> QQbar, I think.

comment:3 Changed 4 years ago by mhansen

  • Reviewers set to Mike Hansen
  • Summary changed from [with patch, needs review] Make an algebraic closure function to [with patch, positive review] Make an algebraic closure function

Looks good to me.

comment:4 Changed 4 years ago by mvngu

  • Status changed from new to closed
  • Resolution set to fixed
  • Merged in set to Sage 4.1.2.alpha2
Note: See TracTickets for help on using tickets.