Ticket #3818 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch; positive review] COPYING.txt doesn't mention jmol but it should

Reported by: was Owned by: mabshoff
Priority: minor Milestone: sage-3.1
Component: distribution Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

There's nothing in SAGE_ROOT/COPYING.txt about jmol, but there should be. It's GPL'd.

Attachments

COPYING.txt Download (70.2 KB) - added by was 5 years ago.
this file should replace the existing COPYING.txt; this is a modification of the one in sage-3.1.alpha1

Change History

comment:1 Changed 5 years ago by was

  • Priority changed from major to minor

Changed 5 years ago by was

this file should replace the existing COPYING.txt; this is a modification of the one in sage-3.1.alpha1

comment:2 Changed 5 years ago by was

  • Summary changed from COPYING.txt doesn't mention jmol but it shold to [with patch; needs review] COPYING.txt doesn't mention jmol but it shold

comment:3 Changed 5 years ago by mabshoff

Even though this is not a patch the diff looks good to me. Positive review.

Cheers,

Michael

comment:4 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.1.alpha2

comment:5 Changed 5 years ago by mabshoff

  • Summary changed from [with patch; needs review] COPYING.txt doesn't mention jmol but it shold to [with patch; positive review] COPYING.txt doesn't mention jmol but it should
Note: See TracTickets for help on using tickets.