Ticket #3780 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

[with patch, positive review] add fast col_swap method for dense matrices over GF(2).

Reported by: malb Owned by: malb
Priority: major Milestone: sage-3.1.2
Component: linear algebra Keywords: m4ri
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description (last modified by mhansen) (diff)

depends on #3324

Attachments

m4ri_col_swap.patch Download (2.2 KB) - added by malb 2 years ago.

Change History

Changed 2 years ago by malb

Changed 2 years ago by mhansen

  • summary changed from [with patch, depends on #3324 to [with patch, needs review] depends on #3324

Changed 2 years ago by mhansen

  • description modified (diff)
  • summary changed from [with patch, needs review] depends on #3324 to [with patch, needs review] add fast col_swap method for dense matrices over GF(2).

Changed 2 years ago by rlm

  • summary changed from [with patch, needs review] add fast col_swap method for dense matrices over GF(2). to [with patch, positive review] add fast col_swap method for dense matrices over GF(2).

I haven't tested this, but it looks fine. If it works, apply.

Changed 2 years ago by rlm

...other than the missing output from the last doctest! :-[

Changed 2 years ago by mabshoff

Note that the doctests only pass with #3376 applied, where the missing output that rlm mentions above is actually added :)

Cheers,

Michael

Changed 2 years ago by mabshoff

  • status changed from new to closed
  • resolution set to fixed

Merged in Sage 3.1.2.alpha3

Changed 2 years ago by mabshoff

Note that the patch attached to this ticket is a diff. I did commit it in Martin's name.

Cheers,

Michael

Note: See TracTickets for help on using tickets.