Ticket #3703 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[with patch, positive review] bug in set_edge_label

Reported by: rlm Owned by: rlm
Priority: major Milestone: sage-3.1
Component: graph theory Keywords:
Cc: Author(s):
Report Upstream: Reviewer(s):
Merged in: Work issues:

Description 

sage: G = Graph({0:{1:1}}, implementation='c_graph')
sage: G.num_edges()
1
sage: G.set_edge_label(0,1,1)
sage: G.num_edges()
2

Attachments

trac3703-set_edge_label.patch Download (2.0 KB) - added by rlm 2 years ago.

Change History

Changed 2 years ago by rlm

  Changed 2 years ago by jason

  • summary changed from [with patch, needs review] bug in set_edge_label to [with patch, positive review] bug in set_edge_label

Positive review. Good catch!

Passes doctests in graphs/*.py, graphs/*.pyx, and graphs/base/*.pyx

  Changed 2 years ago by rlm

I spent most of a day hunting for this one; I wasn't expecting to find it where I did. I was writing new code, so I was convinced it was there...

  Changed 2 years ago by jason

That's a nice blog post you have talking about finding this bug:

 http://rlmill.blogspot.com/2008/07/adinkras.html

  Changed 2 years ago by was

  • milestone changed from sage-3.0.6 to sage-3.1

follow-up: ↓ 6   Changed 2 years ago by rlm

This has been sitting positively reviewed for several release cycles now. What's going on??

in reply to: ↑ 5   Changed 2 years ago by mabshoff

Replying to rlm:

This has been sitting positively reviewed for several release cycles now. What's going on??

3.0.5 was supposed to be ultra stable, but one bug introduced mandated another 3.0.6 stable release. So this patch fell by the side. It will be merged in 3.1.alpha0 in a couple minutes provided the doctests pass.

Cheers,

Michael

  Changed 2 years ago by mabshoff

  • status changed from new to closed
  • resolution set to fixed

Merged in Sage 3.1.alpha0

Note: See TracTickets for help on using tickets.