Ticket #3687 (closed defect: fixed)
[with patch, positive review] trivial problems in the sage_scripts spkg
| Reported by: | tabbott | Owned by: | mabshoff |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-4.1.1 |
| Component: | packages: standard | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | Reviewers: | Adam Webb | |
| Authors: | Tim Abbott | Merged in: | Sage 4.1.1.alpha1 |
| Dependencies: | Stopgaps: |
Description
Below is a list trivial problems in the sage_scripts spkg that were found by Debian's automatic package quality checking tools:
# Scripts missing #!/bin/sh lines in sage_scripts-3.0.5.spkg: sage-pull sage-push sage-mirror sage-mirror-darcs-scripts sage-osx-open
# Scripts missing #!/usr/bin/python lines in sage_scripts-3.0.5.dpkg: sage-startuptime.py sage-gdb-pythonstartup dsage_setup.py
# Files unnecessarily marked as executable in sage_scripts-3.0.5.spkg sage-banner sage-gdb-commands sage-maxima.lisp
# Scripts that use #!sage or #!sage.bin as their interpreter in sage_scripts-3.0.5.spkg # You want to use #!/usr/bin/env sage sage-ipython sage-location sage-preparse sage-run sage-run2
# Weird files in sage_scripts-3.0.5.spkg marked executable sage-README-osx.txt (duplicate of file of the same name in the root of the sage distribution) sage-verify-pyc (this one is just weird)
Attachments
Change History
comment:2 Changed 4 years ago by tabbott
- Summary changed from trivial problems in the sage_scripts spkg to [with patch, needs review] trivial problems in the sage_scripts spkg
Along with applying the attached patch, one should run
chmod -x sage-banner sage-gdb-commands sage-maxima.lisp sage-README-osx.txt sage-verify-pyc
comment:3 Changed 4 years ago by awebb
- Summary changed from [with patch, needs review] trivial problems in the sage_scripts spkg to [with patch, positive review] trivial problems in the sage_scripts spkg
I applied the patch and ran the chmod command as suggested above.
Note: I applied #3686, #3687, #3688 and #3689 at the same time as my machine is a bit slow (8800 s to run all tests). I changed the packages, did a full build from source and ran 'make testlong'. Everything built and all tests passed. This is with Sage-4.1.


Let's try that again with proper formatting:
# Scripts missing #!/bin/sh lines in sage_scripts-3.0.5.spkg:
# Scripts missing #!/usr/bin/python lines in sage_scripts-3.0.5.dpkg:
# Files unnecessarily marked as executable in sage_scripts-3.0.5.spkg
# Scripts that use #!sage or #!sage.bin as their interpreter in sage_scripts-3.0.5.spkg # You want to use #!/usr/bin/env sage
# Weird files in sage_scripts-3.0.5.spkg marked executable