Ticket #3676 (closed enhancement: fixed)

Opened 5 months ago

Last modified 4 months ago

[with patch, positive review] Refactor graph isom code.

Reported by: rlm Assigned to: rlm
Priority: major Milestone: sage-3.1
Component: combinatorics Keywords: graphs
Cc: boothby

Description

After this patch, graph_isom will be essentially obsolete. Brought to the GNU General Public by Google, Inc.

Attachments

trac3676-refactor_graph_isom.patch (79.4 kB) - added by rlm on 07/18/2008 05:08:13 PM.
trac3676-bitset_pxd.patch (3.8 kB) - added by rlm on 07/29/2008 01:44:41 PM.
trac3676-cleanup.patch (3.4 kB) - added by rlm on 08/06/2008 10:39:33 AM.
trac3676-cleanup2.patch (3.9 kB) - added by rlm on 08/06/2008 11:02:41 AM.
trac3676-cleanup3.patch (1.2 kB) - added by rlm on 08/06/2008 03:41:28 PM.
3676-ncalexan-docstring-changes.patch (4.8 kB) - added by ncalexan on 08/11/2008 11:34:19 AM.
trac_3676-graph_isom_refactor.patch (88.0 kB) - added by rlm on 08/11/2008 06:29:42 PM.
Apply only this patch (please do not delete the others!)

Change History

07/18/2008 05:08:13 PM changed by rlm

  • attachment trac3676-refactor_graph_isom.patch added.

07/18/2008 05:08:30 PM changed by rlm

  • cc set to boothby.

07/18/2008 10:27:47 PM changed by wdj

FYI, I got the following test failure: 

wdj@hera:~/sagefiles/sage-3.0.4.rc0$ ./sage -t  devel/sage/sage/rings/finite_field_ntl_gf2e.pyx
sage -t  devel/sage/sage/rings/finite_field_ntl_gf2e.pyx    **********************************************************************
File "/home/wdj/sagefiles/sage-3.0.4.rc0/tmp/finite_field_ntl_gf2e.py", line 170:
    sage: k.modulus()
Expected:
    x^17 + x^16 + x^15 + x^10 + x^8 + x^6 + x^4 + x^3 + x^2 + x + 1
Got:
    x^17
**********************************************************************
1 items had failures:
   1 of   7 in __main__.example_2
***Test Failed*** 1 failures.
For whitespace errors, see the file /home/wdj/sagefiles/sage-3.0.4.rc0/tmp/.doctest_finite_field_ntl_gf2e.py
         [2.9 s]
exit code: 1024

----------------------------------------------------------------------
The following tests failed:


        sage -t  devel/sage/sage/rings/finite_field_ntl_gf2e.pyx
Total time for all tests: 2.9 seconds

07/19/2008 06:20:48 AM changed by mabshoff

David,

the above doctest is a known issue and orthogonal to rlm's code. See #3634 for the patch that likely caused this.

Cheers,

Michael

07/19/2008 06:51:21 AM changed by wdj

Okay. I was just trying to help out with the doctesting, that's all. Seems like it tests fine then.

07/29/2008 01:44:41 PM changed by rlm

  • attachment trac3676-bitset_pxd.patch added.

08/04/2008 10:28:26 AM changed by boothby

It's so... readable...

08/06/2008 10:39:33 AM changed by rlm

  • attachment trac3676-cleanup.patch added.

08/06/2008 10:43:32 AM changed by rlm

The patches here may depend on #3703.

08/06/2008 11:02:41 AM changed by rlm

  • attachment trac3676-cleanup2.patch added.

08/06/2008 12:08:34 PM changed by rlm

  • milestone changed from sage-3.1.1 to sage-3.1.

08/06/2008 03:41:28 PM changed by rlm

  • attachment trac3676-cleanup3.patch added.

08/06/2008 03:41:56 PM changed by rlm

I can flatten those last three if desired...

08/10/2008 01:19:08 PM changed by mabshoff

Once this ticket is merged #3786 should be next.

Cheers,

Michael

08/11/2008 11:34:19 AM changed by ncalexan

  • attachment 3676-ncalexan-docstring-changes.patch added.

08/11/2008 11:35:49 AM changed by ncalexan

  • summary changed from [with patch, needs review] Refactor graph isom code. to [with patch, needs review, review in progress] Refactor graph isom code..

3676-ncalexan-docstring-changes.patch changes some documentation to be clearer.

I am happy with this patch, save for a missing module docstring. rlmiller will write said docstring, explaining programming API to his code, and then this is ready for showtime.

Apply all patches in order.

08/11/2008 03:07:14 PM changed by boothby

Looks good to me.

08/11/2008 06:11:46 PM changed by rlm

The last patch is a flattened version of the previous ones, together with a recipe for implementing other objects. It should be finally ready to go. Apply only the last patch.

08/11/2008 06:29:42 PM changed by rlm

  • attachment trac_3676-graph_isom_refactor.patch added.

Apply only this patch (please do not delete the others!)

08/11/2008 06:31:44 PM changed by ncalexan

  • summary changed from [with patch, needs review, review in progress] Refactor graph isom code. to [with patch, positive review] Refactor graph isom code..

rlm and I have gone back and forth on this and I think it's great. I say apply!

08/11/2008 10:00:53 PM changed by mabshoff

  • status changed from new to closed.
  • resolution set to fixed.

Merged in Sage 3.1.alpha2