Ticket #3669 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

[with patch; with positive review] improve multiple_of_order command for torsion subgroups of modular abelian varieties

Reported by: was Owned by: was
Priority: major Milestone: sage-3.0.6
Component: number theory Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description (last modified by craigcitro) (diff)


Attachments

sage-3669.patch Download (4.3 KB) - added by was 5 years ago.

Change History

Changed 5 years ago by was

comment:1 Changed 5 years ago by craigcitro

  • Description modified (diff)
  • Summary changed from [with patch; needs review] improve multiple_of_order command for torsion subgroups of modular abelian varieties to [with patch; with positive review] improve multiple_of_order command for torsion subgroups of modular abelian varieties

comment:2 Changed 5 years ago by craigcitro

  • Description modified (diff)

This looks good. I might consider switching self.multiple_of_order to self._multiple_of_order, but no other complaints at all.

comment:3 Changed 5 years ago by craigcitro

Mind you, that should say self.__multiple_of_order to self._multiple_of_order. Silly trac markup.

comment:4 Changed 5 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in Sage 3.0.6.alpha1

Note: See TracTickets for help on using tickets.